Re: kernel32: Print a FIXME only once in LCMapStringEx

[Andrew Eikum]

On Mon, Apr 25, 2016 at 04:58:55PM +0200, Louis Lenders wrote:
> diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c
> index 7418da9..8901870 100644
> --- a/dlls/kernel32/locale.c
> +++ b/dlls/kernel32/locale.c
> @@ -2974,10 +2974,13 @@ INT WINAPI LCMapStringEx(LPCWSTR name, DWORD flags, LPCWSTR src, INT srclen, LPW
>                           LPNLSVERSIONINFO version, LPVOID reserved, LPARAM lparam)
>  {
>      LPWSTR dst_ptr;
> +    static int once;
>
> if (version) FIXME("unsupported version structure %p\n", version);
>      if (reserved) FIXME("unsupported reserved pointer %p\n", reserved);
> -    if (lparam) FIXME("unsupported lparam %lx\n", lparam);
> +
> +    if (!once++)
> +        if (lparam) FIXME("unsupported lparam %lx\n", lparam);

I think you got the if statements backwards here. You should print the
first time lparam is non-zero, not only if it's non-zero on the first
LCMapStringEx call.

Andrew