Re: [PATCH] wined3d: When releasing resources, don't perform any other operations on device if it has been released.

[Henri Verbeet]

This looks wrong. Is there a legitimate way that this can happen?

[PATCH] wined3d: When releasing resources, don't perform any other operations on device if it has been released.

[Christian Costa]

Le 31/03/2012 22:46, Henri Verbeet a écrit :
> This looks wrong. Is there a legitimate way that this can happen?

The FIXME in wined3d_device_decref says :

FIXME("Device released with resources still bound, acceptable but 
unexpected.\n");

If this is "acceptable", resources must not use the device afterwards 
because it's released.

If it's legitimate ? I don't know. The game craches when exiting. This 
may be due to a bad objects and resources freeing.
Do you have a better idea ?

Btw, the problem is easily reproductible. The bugzlla entry contain the 
download link.

Christian

[PATCH] wined3d: When releasing resources, don't perform any other operations on device if it has been released.

[Henri Verbeet]

On 31 March 2012 23:30, Christian Costa <titan.costa(a)gmail.com> wrote:
> Do you have a better idea ?

My first guess would be to check if vertex buffers are perhaps
supposed to take a reference to the D3D interface.
> Btw, the problem is easily reproductible. The bugzlla entry contain the
> download link.

Yes, we have a lot of those.

[PATCH] wined3d: When releasing resources, don't perform any other operations on device if it has been released.

[Christian Costa]

Le 01/04/2012 01:49, Henri Verbeet a écrit :
> My first guess would be to check if vertex buffers are perhaps
> supposed to take a reference to the D3D interface.

Ok. I will write a test to check that.