[PATCH] comctl32/header: Mark other timeout values as broken.

[Detlef Riekenberg]

The default timeout for the header-filter is not always 1000
(Mark the other values as brocken() seems resonable)

Example failures:
comctl32  (5.82.9600.17810): 680
http://test.winehq.org/data/75aa4ab16b03a11464ab0d3e4c4cfbff0180c269/win8_dr...

comctl32 (5.82.17763.1): 1100
http://test.winehq.org/data/f9301c2b66450a1cdd986e9052fcaa76535ba8b7/win10_d...

Patch tested:
https://testbot.winehq.org/JobDetails.pl?Key=51459

--
bye bye ...
        ... Detlef

Signed-off-by: Detlef Riekenberg <wine.dev(a)web.de>
---
 dlls/comctl32/tests/header.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/comctl32/tests/header.c b/dlls/comctl32/tests/header.c
index 3428936cd7..206e4c02d9 100644
--- a/dlls/comctl32/tests/header.c
+++ b/dlls/comctl32/tests/header.c
@@ -1017,13 +1017,13 @@ static void test_hdm_filterMessages(HWND hParent)
                                     "adder header control to parent", FALSE);

     timeout = SendMessageA(hChild, HDM_SETFILTERCHANGETIMEOUT, 0, 0);
-    ok(timeout == 1000, "got %d\n", timeout);
+    ok((timeout == 1000) || broken((timeout == 1100) || (timeout == 680)), "got %d\n", timeout);

     timeout = SendMessageA(hChild, HDM_SETFILTERCHANGETIMEOUT, 0, 0);
-    ok(timeout == 1000, "got %d\n", timeout);
+    ok((timeout == 1000) || broken((timeout == 1100) || (timeout == 680)), "got %d\n", timeout);

     timeout = SendMessageA(hChild, HDM_SETFILTERCHANGETIMEOUT, 0, -100);
-    ok(timeout == 1000, "got %d\n", timeout);
+    ok((timeout == 1000) || broken((timeout == 1100) || (timeout == 680)), "got %d\n", timeout);

     timeout = SendMessageA(hChild, HDM_SETFILTERCHANGETIMEOUT, 1, 100);
     ok(timeout == -100, "got %d\n", timeout);
--
2.21.0.windows.1

[Nikolay Sivov]

On Wed, Apr 24, 2019 at 6:47 PM Detlef Riekenberg <wine.dev(a)web.de> wrote:
> The default timeout for the header-filter is not always 1000
> (Mark the other values as brocken() seems resonable)

I don't think it's reasonable. It probably depends on some system timer
setting (or theme parameter if those exist). Just silencing failures is not
useful in my opinion.