Re: d3dx9_36: add D3DXDisassembleShader stub (try 2)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-02-05 um 05:14 schrieb Austin English:
+HRESULT WINAPI D3DXDisassembleShader(const DWORD *shader, BOOL colorcode, LPCSTR comments, LPD3DXBUFFER *disassembly) Please no LPCRAP:
LPCSTR -> const char * LPD3DXBUFFER * -> ID3DXBuffer ** It is even written this way in our header. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU0yySAAoJEN0/YqbEcdMwXNsP/RgpIfaoj7Xhc0QXmCfH4Idh 9A9ohj99ZYAgK4QRaxXwNU9Uoys4TpJVxTDZ31C8WgnSosY+RUPt5hHx64Qe7LY+ wCwDC4wGJGZGVdPmlmTdahhQi9G8BauTs9uHcVvMZThllgfhgGHPOjn90muzcSyx PcXd2cOVnzJwaUNmJ7BrFt1luzqdRUW+v0xu31a8wsFFeIMQGA99DEeDu2ZOiu6/ UWArtccpb0QrDP/A4C5+YAuMcQHeQvWbGMrsCnrm3DBCJN46AIlLcQzw73Leq17Q aY3g6uct8SpCXD8p+KNXfe6FU/qe52QFHjI6yVS9FgjYuHwkjUuIH2CN4au7Dq22 WMt9NZI/fys+MZ5ThKmd6W10kMUpbcHHQxWbDf2zbzaGOxWX+vULNVQhMoCppCF6 0PsYhz+A5HadKgbkk28bhoIVDLefEevw/ov4X1veXEwO/0Xyb/YeLF5XiykM2LQG q6cIAik1kpawJ+YIZYILSZUjgxFmR2q5UF+qotucNdQhbNwfai0MdMMxFZMtxeUD OWwEpILVCp8JLPnTaXYt7D231TPsvLdh0hWMUy6Sk0pOsi8wVf5tO21UO3UT9Vas 7GDaW04KyzKBfD6ArONETOKHGYeozvghmPCmTrA/c8JZ69JBCuA+qk4KdjJ4RvKB rTs9Aao9URRAA9Q4PBM/ =c5KR -----END PGP SIGNATURE-----
Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
Am 2015-02-05 um 05:14 schrieb Austin English:
+HRESULT WINAPI D3DXDisassembleShader(const DWORD *shader, BOOL colorcode, LPCSTR comments, LPD3DXBUFFER *disassembly) Please no LPCRAP:
LPCSTR -> const char *
That's how it's supposed to look like - LPCSTR, not const char *. This is a public API, not an internal helper.
LPD3DXBUFFER * -> ID3DXBuffer **
It is even written this way in our header.
Then the header should be fixed instead: https://msdn.microsoft.com/ru-ru/library/windows/desktop/bb172820%28v=vs.85%... -- Dmitry.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-02-05 um 09:56 schrieb Dmitry Timoshkov:
LPCSTR -> const char *
That's how it's supposed to look like - LPCSTR, not const char *. This is a public API, not an internal helper. https://www.winehq.org/pipermail/wine-devel/2010-June/084460.html
Then the header should be fixed instead: https://msdn.microsoft.com/ru-ru/library/windows/desktop/bb172820%28v=vs.85%... Well, no, it is a good place where the header can be visually different from Microsoft's and still be compatible.
Unless you consider something like #define LPCSTR float #include <d3d11.h> an appropriate use of those types. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU0zbQAAoJEN0/YqbEcdMwYzcP/3Kw8OLVDqNqVsBaOjKvl8jG 8flFB9PaM0gC7aXHjbO4kZhruzZTK2tk/VFCYsGARMoVnIKmug7NDEkowVC+FClQ F0bZG0zKdSAVAXtlfqKJX0qBIpOU7plumeSxE4i+hyG1OLBatDw+PcQOQJxbmmyU rud/9/XMD4qqtNTDhTIU6/S34xWWf0trnRSLB3LnnHVOoJBpmKEBirwlO3k5lMuS RAPn5fzyrKY1OgGkFlitQQUmuTwG82BAFrIwJ3+ZVWUwGOnuEHDEna+zkXf6StIr xrmJDgB2vpq2tjvWAvnJdng/ToWDY3tMsyU4k7E8MSVbhKOdHINgxAAAQu8Cv5x8 s9TP0/edmYhA9iXbrQBNbnl1UCiTnOfFhNelIyXC7E0u2AIlnvhch7zcPlg514B0 druV/1o6dfF/zUIfYL21GDgW1U3+NeI3Se+3W4LfwFL0X/YYHxa+u8NO/+Eu2ZwN ALb7g4goOjTmnkGMyyn2Wi4x2QaU3z9lZu61dCNEHftKvg0kWi4TmC89gEsadVDZ OSQdgLxz667lfSjdUXjFBlgBjz25RvyjePq5K4ti3wn1luezoC5QOjGIhFn1RhpL 3xeCECTOMgGaeM+WR0mVsh3adXKLE58kwSUJ+oBP6+iXajfzyWg0aid+uSEnLOL3 05YAl1yuybQYCoJKB6Oy =rnt9 -----END PGP SIGNATURE-----
Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
That's how it's supposed to look like - LPCSTR, not const char *. This is a public API, not an internal helper. https://www.winehq.org/pipermail/wine-devel/2010-June/084460.html
Then the header should be fixed instead: https://msdn.microsoft.com/ru-ru/library/windows/desktop/bb172820%28v=vs.85%... Well, no, it is a good place where the header can be visually different from Microsoft's and still be compatible.
A header can be made visually different without using wrong types for public APIs. -- Dmitry.
participants (2)
-
Dmitry Timoshkov -
Stefan Dösinger