Re: [PATCH] msi: correct buffer overrun in msi_get_deferred_action().

6 Aug 2007

On 8/5/07, William Waghorn <willw(a)litany.me.uk> wrote:
...
---
  dlls/msi/custom.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c
index 390113e..17f581c 100644
--- a/dlls/msi/custom.c
+++ b/dlls/msi/custom.c
@@ -153,7 +153,7 @@ static LPWSTR msi_get_deferred_action(LPCWSTR
action, LPCWSTR actiondata,
          return strdupW(action);
len = lstrlenW(action) + lstrlenW(actiondata) +
-          lstrlenW(usersid) + lstrlenW(prodcode) + 5;
+          lstrlenW(usersid) + lstrlenW(prodcode) + 9;
      deferred = msi_alloc(len * sizeof(WCHAR));
sprintfW(deferred, format, actiondata, usersid, prodcode, action);
This has been properly fixed in git.

-- 
James Hawkins

    

James Hawkins