Re: [PATCH 1/3] advapi32/tests: Add trailing slashes tests for RegOpen/CreateKey

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Fyi, I asked for these tests to be added to demonstrate that rejecting trailing backslashes is the behavior of reg.exe and not the advapi32 functions.

Patch 1 and 2 look good to me, and I made Jonathan aware of the unchecked ret assign in patch 3 on IRC.

Am 2014-11-06 19:03, schrieb Jonathan Vollebregt:
> ---
>  dlls/advapi32/tests/registry.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c
> index 382d8cc..3aff541 100644
> --- a/dlls/advapi32/tests/registry.c
> +++ b/dlls/advapi32/tests/registry.c
> @@ -953,6 +953,11 @@ static void test_reg_open_key(void)
>      ok(hkResult != NULL, "hkResult != NULL\n");
>      RegCloseKey(hkResult);
>
> +    /* trailing slashes */
> +    ret = RegOpenKeyA(HKEY_CURRENT_USER, "Software\\Wine\\Test\\\\", &hkResult);
> +    ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret);
> +    RegCloseKey(hkResult);
> +
>      /* open nonexistent key
>      * check that hkResult is set to NULL
>      */
> @@ -1218,6 +1223,12 @@ static void test_reg_create_key(void)
>          RegCloseKey(hkey1);
>      }
>
> +    /* trailing backslash characters */
> +    ret = RegCreateKeyExA(hkey_main, "Subkey4\\\\", 0, NULL, 0, KEY_NOTIFY, NULL, &hkey1, NULL);
> +    ok(ret == ERROR_SUCCESS, "RegCreateKeyExA failed with error %d\n", ret);
> +    RegDeleteKeyA(hkey1, "");
> +    RegCloseKey(hkey1);
> +
>      /* WOW64 flags - open an existing key */
>      hkey1 = NULL;
>      ret = RegCreateKeyExA(HKEY_LOCAL_MACHINE, "Software", 0, NULL, 0, KEY_READ|KEY_WOW64_32KEY, NULL, &hkey1, NULL);

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUW7s2AAoJEN0/YqbEcdMw3coP/1o0qah4t2dTpAHVXUB08UIZ
IzII9m1g8uGrqffTJWFJqzDR3jDZjanxxCxvsEYO493WX57YZebsTk1jLbL/BYHi
yzuGaukeDhOf0dtPD4xbjjnkg0JMJ5L+8T7SSTVeEj8TEFLwCOABZfAEiwo4O0PP
ISvNF2BQFBULuq2kWVZ4K8piw/LFD+y3Mcodw3uCydsBS0bQ2Xp5YiLOImAqITmi
YxxR+VOQWZ2SFLUUE79Ct7mmWTUkufCaAcj/6HPpgcfsgqUt/VqwEG0oAPrTwnKc
EfmtRrkgLgSQadzKjSbjAnFQghGAUVcAWCXZ09UMCzLiNKf+UvDh/298XYlRvf5Z
Tey30k4Jj6/K+RZfJNQTUIQNImbOvUWWHQFbJ4pIfOGRJi5dH+vig20lHDUB+lE5
cLmEpVhMc3bjb0yyeDeqL1j5p/isedeJCFcj9R2giNQRGRswduiTH5xtV4xUk+oB
Cu716ppFZyUXVMIhL73+P6PiHM/GyDlKAvkTQVN0FMW8v9vtoVmElIIrkmqmnLLz
OcyGRIhd+0YMnZTyvio2nPI23yu+IroKTDiVXjTJEZl0dVPBD4jK6t8RPpfQfY54
USzUa5k2wUKNIWejbK6GkIIA/+TF+UvcRumqo1NTtZ3ZHn7ds4soxhlwdKhOUkLy
0mgdtIWV6Aa2mQoTcNLT
=76OW
-----END PGP SIGNATURE-----