Re: msi: detect registry keypaths

[Alexandre Julliard]

Aric Stewart <aric(a)codeweavers.com> writes:
> -    FIXME("Only working for installed files, not registry keys\n");
> -    if ( GetFileAttributesW(path) != INVALID_FILE_ATTRIBUTES )
> -        rrc = INSTALLSTATE_LOCAL;
> +    if (path[0]=='0')
> +    {
> +        FIXME("Registry entry.. check entry\n");
> +        if (path[0])
> +            rrc = INSTALLSTATE_LOCAL;
> +        else
> +            rrc = INSTALLSTATE_ABSENT;
> +    }

Since path[0] is first checked against '0' this test doesn't seem to
make much sense. What are you trying to do here?

-- 
Alexandre Julliard
julliard(a)winehq.org

msi: detect registry keypaths

[Aric Stewart]

Ahh you are correct, That is unnecessary.  I can rework it or you can 
remove that test.
Thanks for pointing it out.

-aric

Alexandre Julliard wrote:
> Aric Stewart <aric(a)codeweavers.com> writes:
> > -    FIXME("Only working for installed files, not registry keys\n");
> > -    if ( GetFileAttributesW(path) != INVALID_FILE_ATTRIBUTES )
> > -        rrc = INSTALLSTATE_LOCAL;
> > +    if (path[0]=='0')
> > +    {
> > +        FIXME("Registry entry.. check entry\n");
> > +        if (path[0])
> > +            rrc = INSTALLSTATE_LOCAL;
> > +        else
> > +            rrc = INSTALLSTATE_ABSENT;
> > +    }
>
> Since path[0] is first checked against '0' this test doesn't seem to
> make much sense. What are you trying to do here?