Re: [PATCH] comctl32/tests: Fix treeview test failures on French Windows XP.

[Nikolay Sivov]

On 16.10.2017 6:33, Alex Henrie wrote:
> The one testbot machine that's having trouble with these is the one XP
> machine with a French locale:
> http://test.winehq.org/data/de7220e2553764afd5cf8d463110d4ec5b1a6696/index_X...
>
> Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com>
> ---
>  dlls/comctl32/tests/treeview.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c
> index e7ce92cae8..26ba160c60 100644
> --- a/dlls/comctl32/tests/treeview.c
> +++ b/dlls/comctl32/tests/treeview.c
> @@ -220,6 +220,10 @@ static const struct message test_right_click_seq[] = {
>      { WM_RBUTTONDOWN, sent|wparam, MK_RBUTTON },
>      { WM_CAPTURECHANGED, sent|defwinproc },
>      { TVM_GETNEXTITEM, sent|wparam|lparam|defwinproc, TVGN_CARET, 0 },
> +    /* the optional messages below are for French WinXP */
> +    { WM_NCHITTEST, sent|optional },
> +    { WM_SETCURSOR, sent|optional },
> +    { WM_MOUSEFIRST, sent|optional },
>      { 0 }
>  };
>
> @@ -367,6 +371,9 @@ static const struct message parent_vk_return_seq[] = {
>  static const struct message parent_right_click_seq[] = {
>      { WM_NOTIFY, sent|id, 0, 0, NM_RCLICK },
>      { WM_CONTEXTMENU, sent },
> +    /* the optional messages below are for French WinXP */
> +    { WM_NOTIFY, sent|optional },
> +    { WM_SETCURSOR, sent|optional },
>      { 0 }
>  };

If it works, that's great, but comment makes no sense. I find it hard to
believe UI language affects messages sent to windows, must be something
else. Please resend without it.