Re: [3/3] gdiplus: Bitmaps created from a 32-bit dib should be PARGB.

[Dmitry Timoshkov]

Vincent Povirk <madewokherd(a)gmail.com> wrote:
> case 32:
> -            format = PixelFormat32bppRGB;
> +            if (bm.bmBits)
> +                format = PixelFormat32bppPARGB;
> +            else
> +                format = PixelFormat32bppRGB;

Besides the test failure, to my eyes

format = bm.bmBits ? PixelFormat32bppPARGB : PixelFormat32bppRGB;

looks shorter and clearer.

-- 
Dmitry.

[3/3] gdiplus: Bitmaps created from a 32-bit dib should be PARGB.

[Vincent Povirk]

> test failure

I.. might have forgotten this test was in a different file from the
other one I was working on when I went to run it on my Windows VM. In
any case, sorry about the noise, please disregard this last one.