Re: [3/3] gdiplus: Bitmaps created from a 32-bit dib should be PARGB.
4 Dec
2012
4 Dec
'12
3:55 a.m.
Vincent Povirk <madewokherd(a)gmail.com> wrote:
case 32: - format = PixelFormat32bppRGB; + if (bm.bmBits) + format = PixelFormat32bppPARGB; + else + format = PixelFormat32bppRGB;
Besides the test failure, to my eyes format = bm.bmBits ? PixelFormat32bppPARGB : PixelFormat32bppRGB; looks shorter and clearer. -- Dmitry.
4 Dec
4 Dec
3 a.m.
New subject: [3/3] gdiplus: Bitmaps created from a 32-bit dib should be PARGB.
test failure
I.. might have forgotten this test was in a different file from the other one I was working on when I went to run it on my Windows VM. In any case, sorry about the noise, please disregard this last one.
4757
Age (days ago)
4757
Last active (days ago)
1 comments
2 participants
participants (2)
-
Dmitry Timoshkov -
Vincent Povirk