Re: [PATCH 3/6]: msvcp110: Add tr2_sys__Statvfs implementation and test.

[Nikolay Sivov]

On 27.06.2015 20:50, YongHaoHu wrote:
> +typedef struct {
> +    ULONGLONG capacity;
> +    ULONGLONG free;
> +    ULONGLONG available;
> +} space_info;
> +

Is this documented somewhere?
> +        info.capacity = ((ULONGLONG)(total.HighPart)<< 32) + total.LowPart;
> +        info.free = ((ULONGLONG)(free.HighPart)<< 32) + free.LowPart;
> +        info.available = ((ULONGLONG)(available.HighPart)<< 32) + available.LowPart;

I don't think you'll need this if you used QuadPart.

[PATCH 3/6]: msvcp110: Add tr2_sys__Statvfs implementation and test.

[YongHaoHu]

Hi,

On 15/6/28 上午1:59, Nikolay Sivov wrote:
> On 27.06.2015 20:50, YongHaoHu wrote:
> > +typedef struct {
> > +    ULONGLONG capacity;
> > +    ULONGLONG free;
> > +    ULONGLONG available;
> > +} space_info;
> > +
>
> Is this documented somewhere?
> Yeah, it was documented in MSDN[1]. However, the order of the structure 
> is not correct in the document according to my test. What's more, there 
> is a document about the structure in cppreference.com[2], whose order is 
> right.
> > +        info.capacity = ((ULONGLONG)(total.HighPart)<< 32) + 
> > total.LowPart;
> > +        info.free = ((ULONGLONG)(free.HighPart)<< 32) + free.LowPart;
> > +        info.available = ((ULONGLONG)(available.HighPart)<< 32) + 
> > available.LowPart;
>
> I don't think you'll need this if you used QuadPart.

Yes, thank you for your comment. :)

[1]: https://msdn.microsoft.com/en-us//library/hh874909.aspx
[2]: http://en.cppreference.com/w/cpp/experimental/fs/space_info