Re: shell32: Implement Set/GetCurrentViewMode in the default shellview. (try 2)

[Alexandre Julliard]

David Hedberg <david.hedberg(a)gmail.com> writes:
> +
> +            /* Check that all the messages received can be found in vista_plus_msgs. */
> +#define verify_vista_plus_msgs()                                        \
> +            do {                                                        \
> +                UINT i,j, failcount = 0;                                \
> +                for(i = 0; i < sequences[LISTVIEW_SEQ_INDEX]->count; i++) { \
> +                    BOOL found = FALSE;                                 \
> +                    UINT msg = sequences[LISTVIEW_SEQ_INDEX]->sequence[i].message; \
> +                    for(j = 0; vista_plus_msgs[j] != 0; j++)            \
> +                        if(vista_plus_msgs[j] == msg) found = TRUE;     \
> +                    if(!found) {                                        \
> +                        failcount++;                                    \
> +                        trace("Unexpected messaged %d\n", msg);         \
> +                    }                                                   \
> +                }                                                       \
> +                ok(!failcount,"Failed (%d).\n", failcount);             \
> +                flush_sequences(sequences, NUM_MSG_SEQUENCES);          \
> +            } while(0)
> +

Please avoid that sort of thing, make it a separate function instead.

-- 
Alexandre Julliard
julliard(a)winehq.org