Re: msi: Skip the endlines test if the table fails on import

[Paul Vriens]

James Hawkins wrote:
> Hi,
>
> Fixes 33 test failures on win9x.
>
> Changelog:
> * Skip the endlines test if the table fails on import.
>
> dlls/msi/tests/db.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> ------------------------------------------------------------------------

But shouldn't the ok-call stay and be moved after the if? Or is there not much 
extra information when add_table_to_db fails?

-- 
Cheers,

Paul.

msi: Skip the endlines test if the table fails on import

[James Hawkins]

On Mon, Mar 17, 2008 at 1:00 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
> James Hawkins wrote:
> > Hi,
> >
> > Fixes 33 test failures on win9x.
> >
> > Changelog:
> > * Skip the endlines test if the table fails on import.
> >
> > dlls/msi/tests/db.c |    7 ++++++-
> >  1 files changed, 6 insertions(+), 1 deletions(-)
> >
> > ------------------------------------------------------------------------
>
> But shouldn't the ok-call stay and be moved after the if? Or is there not much
>  extra information when add_table_to_db fails?

The ok is kinda pointless after the if statement.  The real tests are
the rest of the oks.

-- 
James Hawkins