Re: [PATCH] Fix REG_MULTI_SZ save fromat - bug 824

[Alexandre Julliard]

"Michal Piaskowski" <piaskal(a)gmail.com> writes:
> Hi!
> This is my first patch for wine. It fixes bug 824.
>
> The problem is that wine stores REG_MULTI_SZ as
> null terminated string and sometimes looses information about data length.
> Without this information wine can't tell if the original string was null
> terminated or not.

I don't think a non null-terminated MULTI_SZ string is very useful. Do
you really have an app that depends on this?

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH] Fix REG_MULTI_SZ save fromat - bug 824

[Michal Piaskowski]

I don't know of any such application.
It's just an old bug and one of very few bugs marked as tasklets.
And it seemed very easy to fix, so i tried fixing it.
Plus it's different from the way windows XP does it.

If you think it should stay the way it is now, maybe it should be
resolved with WONTFIX?

-- 
Michał Piaskowski

On Jan 7, 2008 6:11 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> "Michal Piaskowski" <piaskal(a)gmail.com> writes:
> > Hi!
> > This is my first patch for wine. It fixes bug 824.
> >
> > The problem is that wine stores REG_MULTI_SZ as
> > null terminated string and sometimes looses information about data length.
> > Without this information wine can't tell if the original string was null
> > terminated or not.
>
> I don't think a non null-terminated MULTI_SZ string is very useful. Do
> you really have an app that depends on this?
>
> --
> Alexandre Julliard
> julliard(a)winehq.org

[PATCH] Fix REG_MULTI_SZ save fromat - bug 824

[Alexandre Julliard]

"Michal Piaskowski" <piaskal(a)gmail.com> writes:
> I don't know of any such application.
> It's just an old bug and one of very few bugs marked as tasklets.
> And it seemed very easy to fix, so i tried fixing it.
> Plus it's different from the way windows XP does it.
>
> If you think it should stay the way it is now, maybe it should be
> resolved with WONTFIX?

I'm not opposed to fixing it, but changing all strings to hex format is
not a good solution, it makes the file much harder to read and modify.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH] Fix REG_MULTI_SZ save fromat - bug 824

[Michal Piaskowski]

On Jan 7, 2008 7:53 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> "Michal Piaskowski" <piaskal(a)gmail.com> writes:
> > I don't know of any such application.
> > It's just an old bug and one of very few bugs marked as tasklets.
> > And it seemed very easy to fix, so i tried fixing it.
> > Plus it's different from the way windows XP does it.
> >
> > If you think it should stay the way it is now, maybe it should be
> > resolved with WONTFIX?
>
> I'm not opposed to fixing it, but changing all strings to hex format is
> not a good solution, it makes the file much harder to read and modify.

I think it can be done without changing every string to hex.
How about adding \0 at the end of every null terminated sting,
and \0\0 at the end of proper REG_MULTI_SZ value which should
end with an empty string?

I might try to do that.

[PATCH] Fix REG_MULTI_SZ save fromat - bug 824

[Alexandre Julliard]

"Michal Piaskowski" <piaskal(a)gmail.com> writes:
> I think it can be done without changing every string to hex.
> How about adding \0 at the end of every null terminated sting,
> and \0\0 at the end of proper REG_MULTI_SZ value which should
> end with an empty string?

It would work, but this can't be changed now, the file format needs to
remain backwards compatible.

It turns out that it's fairly easy to use hex format only for
non-terminated strings, I put in a fix.

-- 
Alexandre Julliard
julliard(a)winehq.org