Re: [PATCH 3/5] winecfg: Make winecfg resources compilable by a Windows resource compiler
On 7/30/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote:
Subject: [PATCH 3/5] winecfg: Make winecfg resources compilable by a Windows resource compiler
In this case do you mean windres or rc? I ask because if its rc then shouldn't we fix wrc to not accept these sources also? If its windres thats broken I think there is a workaround for the problem. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo
"Steven Edwards" <winehacker(a)gmail.com> wrote:
In this case do you mean windres or rc? I ask because if its rc then shouldn't we fix wrc to not accept these sources also? If its windres thats broken I think there is a workaround for the problem.
This patch is aimed to make winecfg resources compileable by microsoft's rc. I don't think that fixing wrc is worth the trouble. I just played with winecfg under Windows to see how well it behaves there :-) -- Dmitry.
On 30.07.2007 16:37, Dmitry Timoshkov wrote:
"Steven Edwards" <winehacker(a)gmail.com> wrote:
In this case do you mean windres or rc? I ask because if its rc then shouldn't we fix wrc to not accept these sources also? If its windres thats broken I think there is a workaround for the problem.
This patch is aimed to make winecfg resources compileable by microsoft's rc. I don't think that fixing wrc is worth the trouble. I just played with winecfg under Windows to see how well it behaves there :-)
What's the actual problem? Also, wouldn't it be nicer to devise a fix that retains the “fancy” quote characters, instead of replacing them with boring 's? -f.r.
"Frank Richter" <frank.richter(a)gmail.com> wrote:
What's the actual problem?
rc simply doesn't handle \" or "" constructs.
Also, wouldn't it be nicer to devise a fix that retains the “fancy” quote characters, instead of replacing them with boring 's?
The problem is that those characters don't exist in some locales. -- Dmitry.
On 30.07.2007 18:54, Dmitry Timoshkov wrote:
"Frank Richter" <frank.richter(a)gmail.com> wrote:
What's the actual problem?
rc simply doesn't handle \" or "" constructs.
Hm, I have some .rc files here with "" that work just fine with MS' rc. (Tho maybe it's braindead enough to have it supportted in one place but not some other.) And what about other substitutes, like \x22 or \042?
Also, wouldn't it be nicer to devise a fix that retains the “fancy” quote characters, instead of replacing them with boring 's?
The problem is that those characters don't exist in some locales.
But when they exists in the codepage commonly used for a locale, I don't think there is a reason not to employ them? -f.r.
"Frank Richter" <frank.richter(a)gmail.com> wrote:
What's the actual problem?
rc simply doesn't handle \" or "" constructs.
Hm, I have some .rc files here with "" that work just fine with MS' rc.
rc doesn't support embedded or escaped quotes at all. So statements like LTEXT "String with "quotes"",-1,7,7,120,8 or LTEXT "String with \"quotes\"",-1,7,7,120,8 don't work.
(Tho maybe it's braindead enough to have it supportted in one place but not some other.) And what about other substitutes, like \x22 or \042?
No, that doesn't help.
Also, wouldn't it be nicer to devise a fix that retains the “fancy” quote characters, instead of replacing them with boring 's?
The problem is that those characters don't exist in some locales.
But when they exists in the codepage commonly used for a locale, I don't think there is a reason not to employ them?
That would create an additional problem for translators IMO. -- Dmitry.
On 31.07.2007 05:37, Dmitry Timoshkov wrote:
rc doesn't support embedded or escaped quotes at all. So statements like
LTEXT "String with "quotes"",-1,7,7,120,8 or LTEXT "String with \"quotes\"",-1,7,7,120,8
don't work.
The strings I'm using and that work for me look like: LTEXT "String with ""quotes""",-1,7,7,120,8
That would create an additional problem for translators IMO.
Why? -f.r.
"Frank Richter" <frank.richter(a)gmail.com> wrote:
That would create an additional problem for translators IMO.
Why?
Because if that character doesn't exist in their locale they would need to figure out first what that code was supposed to express, and find a suitable replacement next. -- Dmitry.
On 31.07.2007 17:01, Dmitry Timoshkov wrote:
Why?
Because if that character doesn't exist in their locale they would need to figure out first what that code was supposed to express, and find a suitable replacement next.
I suppose a translator could look at the e.g. English original in the appropriate codepage(ie 1252) and easily recognize quote characters - if it can't be gathered from the context. Then finding "a suitable replacement" should be trivial - if you speak a language you likely know what kind of quotes are usually used there. -f.r.
"Frank Richter" <frank.richter(a)gmail.com> wrote:
Why?
Because if that character doesn't exist in their locale they would need to figure out first what that code was supposed to express, and find a suitable replacement next.
I suppose a translator could look at the e.g. English original in the appropriate codepage(ie 1252) and easily recognize quote characters - if it can't be gathered from the context. Then finding "a suitable replacement" should be trivial - if you speak a language you likely know what kind of quotes are usually used there.
That doesn't really match my understanding of not creating additional problems without a real necessity. Without a real gain as well IMO. -- Dmitry.
"Dmitry Timoshkov" <dmitry(a)codeweavers.com> writes:
"Frank Richter" <frank.richter(a)gmail.com> wrote:
I suppose a translator could look at the e.g. English original in the appropriate codepage(ie 1252) and easily recognize quote characters - if it can't be gathered from the context. Then finding "a suitable replacement" should be trivial - if you speak a language you likely know what kind of quotes are usually used there.
That doesn't really match my understanding of not creating additional problems without a real necessity. Without a real gain as well IMO.
Like it or not different languages use different styles of quoting, and you can't force everybody to use single quotes just because a couple of places are escaping " incorrectly. -- Alexandre Julliard julliard(a)winehq.org
"Alexandre Julliard" <julliard(a)winehq.org> wrote:
Like it or not different languages use different styles of quoting, and you can't force everybody to use single quotes just because a couple of places are escaping " incorrectly.
Not a couple of places! It got spreaded by copy/pasting over almost all of .rc files. For what gain? Just because somebody likes "fancy" things? -- Dmitry.
"Dmitry Timoshkov" <dmitry(a)codeweavers.com> writes:
Not a couple of places! It got spreaded by copy/pasting over almost all of .rc files. For what gain? Just because somebody likes "fancy" things?
There's no reason not to use standard quotes just because wrc doesn't detect the wrong escaping. Fix wrc. -- Alexandre Julliard julliard(a)winehq.org
On 31.07.2007 17:44, Dmitry Timoshkov wrote:
"Alexandre Julliard" <julliard(a)winehq.org> wrote:
Like it or not different languages use different styles of quoting, and you can't force everybody to use single quotes just because a couple of places are escaping " incorrectly.
Not a couple of places! It got spreaded by copy/pasting over almost all of .rc files. For what gain? Just because somebody likes "fancy" things?
FWIW, use of "fancy" quotes is sometimes featured in official rules for languages. In German, for example, but likely others, too. Also, while " and ' have obviously a special meaning for the resource compiler and need to be escaped, I doubt ‘’‚‛“”„「」『』 have, so using them in strings - as far as the codepage allows - shouldn't cause any problems. -f.r.
participants (4)
-
Alexandre Julliard -
Dmitry Timoshkov -
Frank Richter -
Steven Edwards