Re: [PATCH 4/5] gdi32: Added font name tests on non English locale.

[Alexandre Julliard]

Qian Hong <fracting(a)gmail.com> writes:
> @@ -4110,7 +4120,9 @@ static void test_fullname2_helper(const char *Family)
>
> bufW[0] = 0;
>          bufA[0] = 0;
> -        ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size), "FAMILY (family name) could not be read\n");
> +        ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, GetSystemDefaultLangID()) ||
> +           get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, TT_MS_LANGID_ENGLISH_UNITED_STATES),

You should avoid that sort of thing, it will be hard to debug,
particularly since get_ttf_nametable_entry itself has ok() calls. Store
the result in a variable instead.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 4/5] gdi32: Added font name tests on non English locale.

[Qian Hong]

Hello,

On Fri, Sep 7, 2012 at 2:28 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> You should avoid that sort of thing, it will be hard to debug,
> particularly since get_ttf_nametable_entry itself has ok() calls. Store
> the result in a variable instead.

Thanks for review!
I've sent a improved version.

-- 
Regards,
Qian Hong

-
Sent from Ubuntu
http://www.ubuntu.com/