re: gdi32: Protect against short sized LOGPALETTE in CreatePalette.
Hi, your patch uses IsBadReadPtr(), but that function is deprecated in favor of using an exception handler. See http://www.winehq.org/pipermail/wine-devel/2006-April/046560.html Here's an example (sorry it's a messy one, it's just the first one google found): http://www.winehq.org/pipermail/wine-patches/2004-November/013791.html Please try recoding using that approach. If you have trouble getting this patch in, you might want to file a bug at http://bugs.winehq.org for your problem and link to your patch; that will record the problem so somebody else can pick it up later. - Dan
"Dan Kegel" <dank(a)kegel.com> wrote:
your patch uses IsBadReadPtr(), but that function is deprecated in favor of using an exception handler. See http://www.winehq.org/pipermail/wine-devel/2006-April/046560.html Here's an example (sorry it's a messy one, it's just the first one google found): http://www.winehq.org/pipermail/wine-patches/2004-November/013791.html
dlls/kernel32/string.c,lstrcpyA should be a better example since the patch above uses an old syntax (and has been rejected due to a different reason). -- Dmitry.
On Tue, Feb 26, 2008 at 11:12 AM, Dan Kegel <dank(a)kegel.com> wrote:
your patch uses IsBadReadPtr(), but that function is deprecated in favor of using an exception handler.
For an explanation as to why IsBad*Ptr is really bad read the following http://blogs.msdn.com/oldnewthing/archive/2006/09/27/773741.aspx -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo
participants (3)
-
Dan Kegel -
Dmitry Timoshkov -
Steven Edwards