Re: [PATCH 7/7] wined3d: Don't use the builtin FFP uniform for the modelview matrix.
18 Mar
2015
18 Mar
'15
7:06 a.m.
On 17 March 2015 at 15:52, Matteo Bruni <mbruni(a)codeweavers.com> wrote:
+void get_identity_matrix(struct wined3d_matrix *mat) +{ + static const struct wined3d_matrix identity = + {{{ + 1.0f, 0.0f, 0.0f, 0.0f, + 0.0f, 1.0f, 0.0f, 0.0f, + 0.0f, 0.0f, 1.0f, 0.0f, + 0.0f, 0.0f, 0.0f, 1.0f, + }}}; + + memcpy(mat, &identity, sizeof(identity)); Shouldn't that just be "*mat = identity;"?
And yeah, if you could split this up a bit that would be nice, as it is I think the state handler changes in particular are a bit hard to review properly.
4012
Age (days ago)
4012
Last active (days ago)
0 comments
1 participants
participants (1)
-
Henri Verbeet