Re: dwmapi: add a stub for DwmDefWindowProc

[Reece Dunn]

On 1 February 2010 04:35, Austin English <austinenglish(a)gmail.com> wrote:

+ BOOL WINAPI DwmDefWindowProc(HWND hwnd, UINT msg, WPARAM wParam,
LPARAM lParam, LRESULT *plResult)

Minor nitpick here -- there is a space before the BOOL return type.

+{
+    FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg);
+
+    return E_NOTIMPL;

But more importantly, you are returning a HRESULT instead of a BOOL
return value. MSDN
(http://msdn.microsoft.com/en-us/library/aa969507%28VS.85%29.aspx)
says that it is a BOOL and should return FALSE if the message was not
handled.

- Reece

dwmapi: add a stub for DwmDefWindowProc

[Austin English]

On Mon, Feb 1, 2010 at 4:10 AM, Reece Dunn <msclrhd(a)googlemail.com> wrote:
> On 1 February 2010 04:35, Austin English <austinenglish(a)gmail.com> wrote:
>
> + BOOL WINAPI DwmDefWindowProc(HWND hwnd, UINT msg, WPARAM wParam,
> LPARAM lParam, LRESULT *plResult)
>
> Minor nitpick here -- there is a space before the BOOL return type.

Fixed.
> +{
> +    FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg);
> +
> +    return E_NOTIMPL;
>
> But more importantly, you are returning a HRESULT instead of a BOOL
> return value. MSDN
> (http://msdn.microsoft.com/en-us/library/aa969507%28VS.85%29.aspx)
> says that it is a BOOL and should return FALSE if the message was not
> handled.

Ah, good point. Yeah, was still a bit tired when I sent that
one....the FIXME was wrong too, which is also corrected here.


-- 
-Austin