Re: patches: Display multiple check marks for multiple signoffs.
Hi,
--- a/patches/update +++ b/patches/update @@ -229,7 +229,7 @@ foreach my $file (sort { $patches{$b}->{"order"} <=> $patches{$a}->{"order"} } k } if (defined($patch->{"signoff"})) { - printf INDEX "<td class=\"checkmark\" onclick=\"toggle_display('$file.signoff')\">✓</td>"; + printf INDEX "<td class=\"checkmark\" onclick=\"toggle_display('$file.signoff')\">%s</td>", "✓" x @{$patch->{"signoff"}}; }
The patch is definitly an improvement, but the problem with the patch is, that right now I can't see that my patch has been signed-off by Aric when looking at it in the patch list ... 129264 New Aric Stewart Re: usp10: Fix ScriptRecordDigitSubstitution spec file entry ✓ ... 129183 Assigned André Hentschel usp10: Fix ScriptRecordDigitSubstitution spec file entry Aric Stewart ✓ ... I think something like that was what Bruno is looking for
On Sun, Jan 29, 2017 at 6:24 PM, André Hentschel <nerv(a)dawncrow.de> wrote:
Hi,
Hi, German friend.
...
The patch is definitly an improvement, but the problem with the patch is, that right now I can't see that my patch has been signed-off by Aric when looking at it in the patch list ... 129264 New Aric Stewart Re: usp10: Fix ScriptRecordDigitSubstitution spec file entry ✓ ... 129183 Assigned André Hentschel usp10: Fix ScriptRecordDigitSubstitution spec file entry Aric Stewart ✓ ...
I think something like that was what Bruno is looking for
It is half-working then, because my patch 129061 is double checked because of Andrew's sign 129073. So it is missing some update after receiving new sign-offs, I don't know. Best wishes, Bruno
On Sun, Jan 29, 2017 at 6:51 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote:
The patch is definitly an improvement, but the problem with the patch is, that right now I can't see that my patch has been signed-off by Aric when looking at it in the patch list ... 129264 New Aric Stewart Re: usp10: Fix ScriptRecordDigitSubstitution spec file entry ✓ ... 129183 Assigned André Hentschel usp10: Fix ScriptRecordDigitSubstitution spec file entry Aric Stewart ✓ ...
I think something like that was what Bruno is looking for
It is half-working then, because my patch 129061 is double checked because of Andrew's sign 129073. So it is missing some update after receiving new sign-offs, I don't know.
Judging by the current contents of the list I infer that the other signs are only added after the email is marked as Sign-off type.
Am 29.01.2017 um 21:56 schrieb Bruno Jesus:
On Sun, Jan 29, 2017 at 6:51 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote:
The patch is definitly an improvement, but the problem with the patch is, that right now I can't see that my patch has been signed-off by Aric when looking at it in the patch list ... 129264 New Aric Stewart Re: usp10: Fix ScriptRecordDigitSubstitution spec file entry ✓ ... 129183 Assigned André Hentschel usp10: Fix ScriptRecordDigitSubstitution spec file entry Aric Stewart ✓ ...
I think something like that was what Bruno is looking for
It is half-working then, because my patch 129061 is double checked because of Andrew's sign 129073. So it is missing some update after receiving new sign-offs, I don't know.
Judging by the current contents of the list I infer that the other signs are only added after the email is marked as Sign-off type.
Yeah, think so too
Bruno Jesus <00cpxxx(a)gmail.com> writes:
On Sun, Jan 29, 2017 at 6:51 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote:
The patch is definitly an improvement, but the problem with the patch is, that right now I can't see that my patch has been signed-off by Aric when looking at it in the patch list ... 129264 New Aric Stewart Re: usp10: Fix ScriptRecordDigitSubstitution spec file entry ✓ ... 129183 Assigned André Hentschel usp10: Fix ScriptRecordDigitSubstitution spec file entry Aric Stewart ✓ ...
I think something like that was what Bruno is looking for
It is half-working then, because my patch 129061 is double checked because of Andrew's sign 129073. So it is missing some update after receiving new sign-offs, I don't know.
Judging by the current contents of the list I infer that the other signs are only added after the email is marked as Sign-off type.
Yes, the list is not updated in real time. The patch status is pushed out together with the commits. -- Alexandre Julliard julliard(a)winehq.org
participants (3)
-
Alexandre Julliard -
André Hentschel -
Bruno Jesus