Re: comdlg32: 1/2 PageSetupDlg: Convert paint procs to Unicode
"Alexander Nicolaysen Sørnes" <alex(a)thehandofagony.com> wrote:
comdlg32: 1/2 PageSetupDlg: Convert paint procs to Unicod
What's the purpose of this patch? It improves nothing IMO except of making the code less readable, making it not thread safe, calling CallWindowProcW where it shouldn't. -- Dmitry.
On Monday 31 December 2007 07:39:28 Dmitry Timoshkov wrote:
"Alexander Nicolaysen Sørnes" <alex(a)thehandofagony.com> wrote:
comdlg32: 1/2 PageSetupDlg: Convert paint procs to Unicod
What's the purpose of this patch? It improves nothing IMO except of making the code less readable, making it not thread safe, calling CallWindowProcW where it shouldn't.
I made these changes so that the PageSetupDlgA/W could share the paper preview code, which the W variant currently doesn't have (preview added in patch 2/2). I would be grateful if you could suggest ways to improve the code, but if it's completely hopeless I'll accept that. :) Alexander N. Sørnes
On Monday 31 December 2007 07:39:28 Dmitry Timoshkov wrote:
"Alexander Nicolaysen Sørnes" <alex(a)thehandofagony.com> wrote:
comdlg32: 1/2 PageSetupDlg: Convert paint procs to Unicod
What's the purpose of this patch? It improves nothing IMO except of making the code less readable, making it not thread safe, calling CallWindowProcW where it shouldn't.
Would it be better to have separate A/W painting functions? Alexander
On Sunday 06 January 2008 15:29:46 Dmitry Timoshkov wrote:
"Alexander Nicolaysen Sørnes" <alex(a)thehandofagony.com> wrote:
Would it be better to have separate A/W painting functions?
What that would improve?
Nothing that I can think of, but you know the code much beter than me. It just seemed like you disagreed with the intention of my original patch as well as the patch itself. Alexander
participants (2)
-
Alexander Nicolaysen Sørnes -
Dmitry Timoshkov