Re: [15/17] gdiplus: Delete GDI objects once they are not needed anymore.

[Vincent Povirk]

This will break text rendering. We need the correct font to be
selected on the hdc during the call to gdip_format_string.

[15/17] gdiplus: Delete GDI objects once they are not needed anymore.

[Dmitry Timoshkov]

Vincent Povirk <madewokherd(a)gmail.com> wrote:
> This will break text rendering. We need the correct font to be
> selected on the hdc during the call to gdip_format_string.

GdipDrawDriverString creates and selects the font on the DC.

-- 
Dmitry.

[15/17] gdiplus: Delete GDI objects once they are not needed anymore.

[Vincent Povirk]

Yes, but gdip_format_string still uses the HDC to do measurements for
the layout calculation. (And draw_string_callback uses it to decide
where to draw underlines.)

On Wed, Aug 8, 2012 at 11:53 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
> Vincent Povirk <madewokherd(a)gmail.com> wrote:
> > This will break text rendering. We need the correct font to be
> > selected on the hdc during the call to gdip_format_string.
>
> GdipDrawDriverString creates and selects the font on the DC.
>
> --
> Dmitry.

[15/17] gdiplus: Delete GDI objects once they are not needed anymore.

[Dmitry Timoshkov]

Vincent Povirk <madewokherd(a)gmail.com> wrote:
> Yes, but gdip_format_string still uses the HDC to do measurements for
> the layout calculation. (And draw_string_callback uses it to decide
> where to draw underlines.)

You are right, this patch can be dropped then, #16 and #17 don't depend
on this one.

-- 
Dmitry.