[PATCH] kernel32/tests: Fix sprintf() arguments (Coverity).
Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/kernel32/tests/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/kernel32/tests/console.c b/dlls/kernel32/tests/console.c index 3003ff63f5a..0bce88716d0 100644 --- a/dlls/kernel32/tests/console.c +++ b/dlls/kernel32/tests/console.c @@ -4444,7 +4444,7 @@ static void test_AllocConsole(void) if (skip_nt) return; winetest_get_mainargs(&argv); - sprintf(buf, "\"%s\" console alloc_console", argv[0], GetCurrentProcessId()); + sprintf(buf, "\"%s\" console alloc_console", argv[0]); res = CreateProcessA(NULL, buf, NULL, NULL, FALSE, CREATE_NEW_CONSOLE, NULL, NULL, &si, &info); ok(res, "CreateProcess failed: %u\n", GetLastError()); CloseHandle(info.hThread); -- 2.33.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=97929 Your paranoid android. === w10pro64 (32 bit report) === kernel32: console.c:1186: Test failed: WaitForSingleObject returned 0 console.c:1188: Test failed: WaitForSingleObject returned 0 console.c:1190: Test failed: WaitForSingleObject returned 0 console.c:1192: Test failed: WaitForSingleObject returned 0 console.c:1194: Test failed: WaitForSingleObject returned 0 console.c:1196: Test failed: NtWaitForSingleObject returned 0 console.c:1199: Test failed: NtWaitForSingleObject returned 0
participants (2)
-
Marvin -
Nikolay Sivov