Re: user32, wined3d: move refresh rate fallback to catch all cases (resend)
"Erik Inge Bolsø" <knan-wine(a)anduin.net> wrote:
If requesting a refresh rate that isn't available, but a better one is, ChangeDisplaySettings fails and some games fail to launch. This does not seem to match WinXP behaviour with the same graphics card + lcd monitor combination.
If that's not what Windows does then this patch can't be accepted. In any case a test case showing Windows behaviour is required. -- Dmitry.
On Tue, 15 Jan 2008, Dmitry Timoshkov wrote:
"Erik Inge Bolsø" <knan-wine(a)anduin.net> wrote:
If requesting a refresh rate that isn't available, but a better one is, ChangeDisplaySettings fails and some games fail to launch. This does not seem to match WinXP behaviour with the same graphics card + lcd monitor combination.
If that's not what Windows does then this patch can't be accepted. In any case a test case showing Windows behaviour is required.
This is a change to match windows behaviour, AFAICT. How would I go about adding a testcase for this? I don't have a windows development environment set up, and only indirectly a windows install to test on. Can't mess around with it too much, it's not mine. -- -erik http://useofwords.blogspot.com/
"Erik Inge Bolsø" <knan-wine(a)anduin.net> wrote:
This is a change to match windows behaviour, AFAICT.
Based on what?
How would I go about adding a testcase for this? I don't have a windows development environment set up, and only indirectly a windows install to test on. Can't mess around with it too much, it's not mine.
If you haven't tested this in Windows then I don't see how you could claim that your patch makes Wine conform to Windows behaviour. A test I'd think of would scan available video modes, choose one, change its refresh rate so that the modes of the same resolution have different values, and see what happens if you pass it to ChangeDisplaySettings. -- Dmitry.
On Tue, 15 Jan 2008, Dmitry Timoshkov wrote:
"Erik Inge Bolsø" <knan-wine(a)anduin.net> wrote:
This is a change to match windows behaviour, AFAICT.
Based on what?
How would I go about adding a testcase for this? I don't have a windows development environment set up, and only indirectly a windows install to test on. Can't mess around with it too much, it's not mine.
If you haven't tested this in Windows then I don't see how you could claim that your patch makes Wine conform to Windows behaviour.
As I said last time I tried to submit this, the game starts in Windows XP on an identical graphics card + lcd monitor combination. (50 Hz is not available there either.) It does not start in Wine. This allows it to start, but I'm not 100% certain it fixes it in the right place. -- -erik http://useofwords.blogspot.com/
"Erik Inge Bolsø" <knan-wine(a)anduin.net> wrote:
As I said last time I tried to submit this, the game starts in Windows XP on an identical graphics card + lcd monitor combination. (50 Hz is not available there either.) It does not start in Wine. This allows it to start, but I'm not 100% certain it fixes it in the right place.
It should be investigated first where an invalid refresh rate comes from, i.e. you are fixing the real problem and not a subsequence of a bug somewhere else. -- Dmitry.
participants (2)
-
Dmitry Timoshkov -
Erik Inge Bolsø