[PATCH] ucrtbase/tests: add tests for strftime formats %r and %V
Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> --- dlls/ucrtbase/tests/misc.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/dlls/ucrtbase/tests/misc.c b/dlls/ucrtbase/tests/misc.c index 8a6fb7b8e11b..391cff79f81b 100644 --- a/dlls/ucrtbase/tests/misc.c +++ b/dlls/ucrtbase/tests/misc.c @@ -904,6 +904,7 @@ static void test_strftime(void) { const struct tm epoch = { 0, 0, 0, 1, 0, 70, 4, 0, 0 }; const struct tm tm1 = { 0, 0, 0, 1, 0, 117, 0, 0, 0 }; + const struct tm tm2 = { 0, 0, 14, 1, 0, 122, 6, 0, 0 }; char bufA[256]; size_t retA; int i; @@ -964,6 +965,14 @@ static void test_strftime(void) ok(retA == 1, "expected 1, got %d\n", (int)retA); ok(!strcmp(bufA, "\n"), "got %s\n", bufA); + retA = p_strftime(bufA, sizeof(bufA), "%r", &epoch); + todo_wine ok(retA == 11, "expected 11, got %d\n", (int)retA); + todo_wine ok(!strcmp(bufA, "12:00:00 AM"), "got %s\n", bufA); + + retA = p_strftime(bufA, sizeof(bufA), "%r", &tm2); + todo_wine ok(retA == 11, "expected 11, got %d\n", (int)retA); + todo_wine ok(!strcmp(bufA, "02:00:00 PM"), "got %s\n", bufA); + retA = p_strftime(bufA, sizeof(bufA), "%t", &epoch); ok(retA == 1, "expected 1, got %d\n", (int)retA); ok(!strcmp(bufA, "\t"), "got %s\n", bufA); @@ -984,6 +993,18 @@ static void test_strftime(void) ok(retA == 4, "expected 4, got %d\n", (int)retA); ok(!strcmp(bufA, "2016"), "got %s\n", bufA); + retA = p_strftime(bufA, sizeof(bufA), "%V", &epoch); + todo_wine ok(retA == 2, "expected 2, got %d\n", (int)retA); + todo_wine ok(!strcmp(bufA, "01"), "got %s\n", bufA); + + retA = p_strftime(bufA, sizeof(bufA), "%V", &tm1); + todo_wine ok(retA == 2, "expected 2, got %d\n", (int)retA); + todo_wine ok(!strcmp(bufA, "53"), "got %s\n", bufA); + + retA = p_strftime(bufA, sizeof(bufA), "%V", &tm2); + todo_wine ok(retA == 2, "expected 2, got %d\n", (int)retA); + todo_wine ok(!strcmp(bufA, "52"), "got %s\n", bufA); + for(i=0; i<14; i++) { __time32_t t = (365*2 + i - 7) * 24 * 60 * 60; -- 2.21.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=58875 Your paranoid android. === w2008s64 (32 bit report) === ucrtbase: misc.c:1002: Test failed: got 52 === w1064v1507 (32 bit report) === ucrtbase: misc.c:1002: Test failed: got 52 === w1064v1809 (32 bit report) === ucrtbase: misc.c:1002: Test failed: got 52 === w1064v1809_2scr (32 bit report) === ucrtbase: misc.c:1002: Test failed: got 52 === w1064v1809_ar (32 bit report) === ucrtbase: misc.c:1002: Test failed: got 52 === w1064v1809_he (32 bit report) === ucrtbase: misc.c:1002: Test failed: got 52 === w1064v1809_ja (32 bit report) === ucrtbase: misc.c:1002: Test failed: got 52 === w1064v1809_zh_CN (32 bit report) === ucrtbase: misc.c:1002: Test failed: got 52 === w2008s64 (64 bit report) === ucrtbase: misc.c:1002: Test failed: got 52 === w1064v1507 (64 bit report) === ucrtbase: misc.c:1002: Test failed: got 52 === w1064v1809 (64 bit report) === ucrtbase: misc.c:1002: Test failed: got 52
participants (2)
-
Marvin -
Vijay Kiran Kamuju