Re: msiexec: Add handling for msiexec's regserver option

[Vitaliy Margolen]

Tuesday, August 22, 2006, 7:56:00 PM, James Hawkins wrote:
> Hi,
> More and more installers are expecting the MSI service to exist, or at
> least be installable using msiexec /regserver.  This patch is the
> first step in fixing bug 5540.
> +    if (!scm)
> +    {
> +        fprintf(stderr, "Failed to open the service control manager.\n");
> +        return 1;
> +    }

Please use proper WINE_[ERR|WARN|FIXME|TRACE] macros.

Vitaliy Margolen

msiexec: Add handling for msiexec's regserver option

[James Hawkins]

On 8/22/06, Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote:
> Tuesday, August 22, 2006, 7:56:00 PM, James Hawkins wrote:
> > Hi,
> > More and more installers are expecting the MSI service to exist, or at
> > least be installable using msiexec /regserver.  This patch is the
> > first step in fixing bug 5540.
> > +    if (!scm)
> > +    {
> > +        fprintf(stderr, "Failed to open the service control manager.\n");
> > +        return 1;
> > +    }
>
> Please use proper WINE_[ERR|WARN|FIXME|TRACE] macros.

If you'll look in msiexec.c, you'll see that fprintf is used
throughout the entire file for error output.  I'm just keeping the
style of the file consistent.

-- 
James Hawkins