Re: wintrust(3/3): Fix a couple tests on a variety of systems
Juan Lang wrote:
--Juan
------------------------------------------------------------------------
This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used skip() for this. -- Cheers, Paul.
Hi Paul,
This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used skip() for this.
Of course that's the reason, but not running as administrator is an acceptable configuration, is it not? I use skip() where subsequent tests will fail as a result of an early failure, but that wasn't the case here. --Juan
Juan Lang wrote:
Hi Paul,
This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used skip() for this.
Of course that's the reason, but not running as administrator is an acceptable configuration, is it not? I use skip() where subsequent tests will fail as a result of an early failure, but that wasn't the case here. --Juan
I guess the main problem lies in the fact that we as Wine are now also accepting ERROR_ACCESS_DENIED and we won't be noticed of this fact. A skip (which is most of the time valid) at least shows us something. -- Cheers, Paul.
2009/2/12 Juan Lang <juan.lang(a)gmail.com>:
Hi Paul,
This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used skip() for this.
Of course that's the reason, but not running as administrator is an acceptable configuration, is it not?
I don't think it should be. There are many variables that can be changed that will cause test failures and this is one of them. We are already putting a lot of effort into fixing tests that fail just because of different versions of DLLs. We don't have the resources to spend ensuring that the tests work in every possible configuration and if many tests are skipped because of them being not being run as Administrator then that isn't going to generate that much of a useful test report. Of course, we should find some way of preventing such reports being filed and one of the ways could be to add a check to the winetest program. -- Rob Shearman
Rob Shearman wrote:
2009/2/12 Juan Lang <juan.lang(a)gmail.com>:
Hi Paul,
This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used skip() for this. Of course that's the reason, but not running as administrator is an acceptable configuration, is it not?
I don't think it should be. There are many variables that can be changed that will cause test failures and this is one of them. We are already putting a lot of effort into fixing tests that fail just because of different versions of DLLs. We don't have the resources to spend ensuring that the tests work in every possible configuration and if many tests are skipped because of them being not being run as Administrator then that isn't going to generate that much of a useful test report.
Of course, we should find some way of preventing such reports being filed and one of the ways could be to add a check to the winetest program.
I sent out an email earlier to ask if we should include more information in the header of the report. We could use that information, if this change will be accepted by AJ, to limit the reporting only to boxes were we have admin rights. As soon as all boxes have zero failures (yeah, right) we can remove that limit. -- Cheers, Paul.
Paul Vriens <paul.vriens.wine(a)gmail.com> writes:
I sent out an email earlier to ask if we should include more information in the header of the report. We could use that information, if this change will be accepted by AJ, to limit the reporting only to boxes were we have admin rights.
As soon as all boxes have zero failures (yeah, right) we can remove that limit.
Yes, we will want to fix these tests eventually, since we will some day support multi-user setups where normal users won't have admin rights, and we will need tests to make sure we fail the right way. But in the meantime we can certainly block these reports and concentrate on the more meaningful failures. -- Alexandre Julliard julliard(a)winehq.org
participants (4)
-
Alexandre Julliard -
Juan Lang -
Paul Vriens -
Rob Shearman