Re: [PATCH 5/7] msi: Perform the given action, or INSTALL, from MsiInstallProduct().

[Hans Leidekker]

On Tue, 2017-09-12 at 20:51 -0500, Zebediah Figura wrote:
> The removed code to re-run all actions after InstallValidate is old
> and not supported by tests.

This makes the tests fail here:

err:msi:ITERATE_Actions Execution halted, action L"Run C" returned 1603
Makefile:326: recipe for target 'install.ok' failed
make: *** [install.ok] Error 1

[PATCH 5/7] msi: Perform the given action, or INSTALL, from MsiInstallProduct().

[Zebediah Figura]

On 09/13/2017 04:15 AM, Hans Leidekker wrote:
> On Tue, 2017-09-12 at 20:51 -0500, Zebediah Figura wrote:
> > The removed code to re-run all actions after InstallValidate is old
> > and not supported by tests.
>
> This makes the tests fail here:
>
> err:msi:ITERATE_Actions Execution halted, action L"Run C" returned 1603
> Makefile:326: recipe for target 'install.ok' failed
> make: *** [install.ok] Error 1

Failing test is:

install.c:3863: Test failed: Expected ERROR_SUCCESS, got 1626

which is due to a test that calls MsiInstallProduct("ACTION=ADMIN"). 
Previously this succeeded since we ignored the given action, so this 
wasn't quite the correct behaviour.

It should be simple enough to fix; should I add a patch to this set or 
just mark the test as todo for the moment?

[PATCH 5/7] msi: Perform the given action, or INSTALL, from MsiInstallProduct().

[Hans Leidekker]

On Wed, 2017-09-13 at 09:49 -0500, Zebediah Figura wrote:
> On 09/13/2017 04:15 AM, Hans Leidekker wrote:
> > On Tue, 2017-09-12 at 20:51 -0500, Zebediah Figura wrote:
> > > The removed code to re-run all actions after InstallValidate is old
> > > and not supported by tests.
> >
> > This makes the tests fail here:
> >
> > err:msi:ITERATE_Actions Execution halted, action L"Run C" returned 1603
> > Makefile:326: recipe for target 'install.ok' failed
> > make: *** [install.ok] Error 1
>
> Failing test is:
>
> install.c:3863: Test failed: Expected ERROR_SUCCESS, got 1626
>
> which is due to a test that calls MsiInstallProduct("ACTION=ADMIN"). 
> Previously this succeeded since we ignored the given action, so this 
> wasn't quite the correct behaviour.
>
> It should be simple enough to fix; should I add a patch to this set or 
> just mark the test as todo for the moment?

I'm fine with marking it todo.