Re: dpnet: Check if DirectDplay is installed (try 4 - resend)

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I don't remember and cannot find out from the archives what happened
to try 1-3.
> +#include "dpnet_private.h"
> I think we want our test files to be stand-alone if possible. Having a
> copy of the code in each file or merging the test files are
> alternatives to giving up this independence. Though at least
> dlls/ntdll/tests/ntdll_test.h is an example of an existing test header.

Another option is to generalize this function beyond dpnet.dll and put
it in include/wine/test.h or make programs/winetest responsible for
checking for stubs. I think programs/winetest is the best place, as it
also handles missing DLLs.

If you keep the header please rename it, along with the protection define.
> +extern BOOL IsStubDLL(const char *filename) DECLSPEC_HIDDEN;
> You have CamelCase in there. You could also consider making this a
> static inline function in the header, that way you avoid dependencies
> between the .c files.
> +/* + * Windows 8 has a concept of stub DLL's.  When DLLMain is
> called the user is prompted
> I think DLLs is the correct plural, DLL's would be the possessive.
> +        LPSTR data = HeapAlloc(GetProcessHeap(), 0, size);
> LPFOO. There are other cases on this code.
> +            if (VerQueryValueA(data,
> "\\StringFileInfo\\040904b0\\OriginalFilename", (LPVOID*)&p,
> &size))
> What's 040904b0? I could not find an explanation on google, so maybe
> there's no way to avoid it.

Cheers,
Stefan

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUSAkhAAoJEN0/YqbEcdMw3y8QAJMwgh4rHP2iHgQV1mPkjSFR
bHMv/CZynb/cd6e8of2oQybSC+iAt4e6MUPqMQCkg0CcsqcDTHf27Ci6r5q+P7Lg
fTxAp2U/Vz5r77cKRejarjNueN62SBet7wDR9Bx8pIZ7+yAQDQ6H2qf5iqHOr5KU
0kjftpeKA9YUy1nuQJEf3wUUqnXEy8tZBL9UqryV6ya+HLzYdwq1SNJunH/rOaFh
QQBM9CQ4HPMvj7BnGmKdQhFdssptaNYLPrK0QUCb/EyroqB0YGQ2QZsINQREKGYl
y8iwjFaMkpIALtXX88UapHfPBn6jc4Y7abaEWm0ReRly1FCkMOgoPIqwLyWIunga
sJalQeULE8ztPh/dseofH7mtOJyWY82JCs2l8F3iTRANwjbJCiZVE/dFJHurs8EZ
0wQ4zNH3wp1HwjYXDxOuVS2phJ9Y1SC30Cjb2jDLotg1NX/5QWLbQvn6R+S1+YV/
AkFbizAFUf6GNhnLTKMB+WC+lChc2ZF57P+H0iFixbpnW8OTNYDKiefKKQuScicE
i6TgiKBTw7pWrn6h+s1GV+nILBsqzO8HqGaTLvvQUGkPKdaxjN/5HJLYQ60Xhg7P
RvLSiYm0xOQNgZyoVCrGlLyiKZg7r192q+Yv9OG4AQ/GQkdeP9PahKmhu9a0WhDt
xD1zmLqLy45erH4m4oa4
=Wf/H
-----END PGP SIGNATURE-----