Re: [PATCH] Enable X11DRV_DIB_GetImageBits_8 in all cases and optimize X11DRV_DIB_GetNearestIndex to fix bug 2666 and other strange behavior

[David Kiefer]

While this patch indeed fixes bug 2666, it also kills performance, at
least with Age of Empires II.
The frame rate in the menu for me is about one frame every three seconds
and about 1 fps in-game.

With the patch, the work previously done by X11DRV_DIB_MapColor is now
done by  X11DRV_DIB_GetNearestIndex. Unlike GetNearestIndex, MapColor
avoids traversing the entire palette most of the time by reusing the
previous index in the destination bitmap if the color has not changed.
However, MapColor only checks for exact matches and returns the first
palette entry if none was found, effectively causing bug 2666.
A possible solution is to have MapColor call GetNearestIndex as a last
resort instead. This both fixes the problem and results in acceptable
performance.

David

[PATCH] Enable X11DRV_DIB_GetImageBits_8 in all cases and optimize X11DRV_DIB_GetNearestIndex to fix bug 2666 and other strange behavior

[Roderick Colenbrander]

On Thu, Sep 29, 2011 at 12:57 PM, David Kiefer <hevanen(a)googlemail.com> wrote:
> While this patch indeed fixes bug 2666, it also kills performance, at
> least with Age of Empires II.
> The frame rate in the menu for me is about one frame every three seconds
> and about 1 fps in-game.
>
> With the patch, the work previously done by X11DRV_DIB_MapColor is now
> done by  X11DRV_DIB_GetNearestIndex. Unlike GetNearestIndex, MapColor
> avoids traversing the entire palette most of the time by reusing the
> previous index in the destination bitmap if the color has not changed.
> However, MapColor only checks for exact matches and returns the first
> palette entry if none was found, effectively causing bug 2666.
> A possible solution is to have MapColor call GetNearestIndex as a last
> resort instead. This both fixes the problem and results in acceptable
> performance.
>
> David

I'm not really sure how useful it is to try to optimize parts of the
X11 code now that the DIB engine is progressing nicely. Once the DIB
engine is done this code will disappear anyway. No need for horrible
X11 hacks to offload any DIB rendering and converting the X11 result
back into a DIB.

Roderick