Re: [PATCH 1/2] server: Add mechanism to retrieve the connect time of a socket (try 2).
"Erich E. Hoover" <ehoover(a)mines.edu> wrote:
+/* Get information about a socket */ +DECL_HANDLER(get_socket_info) +{ + struct sock *sock; + + sock=(struct sock *)get_handle_obj( current->process, req->handle, FILE_WRITE_ATTRIBUTES, &sock_ops );
Shouldn't the required access be FILE_READ_ATTRIBUTES or FILE_READ_PROPERTIES? Why write access is requied in order to read the socket connect time? Also please avoid including auto generated code in the patch. -- Dmitry.
On Wed, Apr 11, 2012 at 1:18 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
"Erich E. Hoover" <ehoover(a)mines.edu> wrote:
... + sock=(struct sock *)get_handle_obj( current->process, req->handle, FILE_WRITE_ATTRIBUTES, &sock_ops );
Shouldn't the required access be FILE_READ_ATTRIBUTES or FILE_READ_PROPERTIES? Why write access is requied in order to read the socket connect time?
Yes, I apologize for that - apparently I wasn't paying enough attention when I checked that over.
Also please avoid including auto generated code in the patch.
Sorry about that, I thought I was supposed to include all of the files checked into the repository. Erich Hoover ehoover(a)mines.edu
participants (2)
-
Dmitry Timoshkov -
Erich E. Hoover