[PATCH] shell32: Free original_dos_name with correct function in TRASH_GetDetails() (Coverity).

[Gijs Vermeulen]

Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com>
---
 dlls/shell32/trash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/shell32/trash.c b/dlls/shell32/trash.c
index 93b4ee4588..f34b106bd6 100644
--- a/dlls/shell32/trash.c
+++ b/dlls/shell32/trash.c
@@ -662,7 +662,7 @@ static HRESULT TRASH_GetDetails(const TRASH_BUCKET *bucket, LPCSTR filename, WIN
     if (original_dos_name != NULL)
     {
         lstrcpynW(data->cFileName, original_dos_name, MAX_PATH);
-        SHFree(original_dos_name);
+        heap_free(original_dos_name);
     }
     else
     {
-- 
2.28.0

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=77281

Your paranoid android.


=== debiant (32 bit WoW report) ===

shell32:
shelllink.c:753: Test failed: save failed (0x80070020)
shelllink.c:753: Test failed: got 0x00000001
shelllink.c:753: Test failed: Didn't expect NULL
shelllink.c:478: Test failed: GetCurFile fails on shell32 < 5.0
shelllink.c:754: Test failed: GetDescription returned 'command on path without .exe' instead of 'non-executable file'
shelllink.c:754: Test failed: GetWorkingDirectory returned 'C:\users\winetest\Temp\wct\shell32_test.exe' instead of 'C:\users\winetest\Temp'
shelllink.c:754: Test failed: GetPath returned 'C:\users\winetest\Temp\wct\rundll32' instead of 'C:\users\winetest\Temp\test.txt'
shelllink.c:754: Test failed: GetIconLocation returned 'C:\users\winetest\Temp\wct\shell32_test.exe' instead of 'C:\users\winetest\Temp\test.txt'