[PATCH] ddraw: Silence noisy FIXME about unimplemented D3DPROCESSVERTICES_UPDATEEXTENTS.

[Gijs Vermeulen]

From: Christian Costa <titan.costa(a)gmail.com>

Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com>
---

Fixes noisy fixme that floods the console (> 1000) in VENOM. CODENAME: OUTBREAK.

 dlls/ddraw/executebuffer.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/ddraw/executebuffer.c b/dlls/ddraw/executebuffer.c
index b20b9eda71..d8b4b39fd4 100644
--- a/dlls/ddraw/executebuffer.c
+++ b/dlls/ddraw/executebuffer.c
@@ -308,7 +308,10 @@ HRESULT d3d_execute_buffer_execute(struct d3d_execute_buffer *buffer,
                             ci->wStart, ci->wDest, ci->dwCount, ci->dwFlags);
 
                     if (ci->dwFlags & D3DPROCESSVERTICES_UPDATEEXTENTS)
-                        FIXME("D3DPROCESSVERTICES_UPDATEEXTENTS not implemented.\n");
+                    {
+                        static int once;
+                        if (!once++) FIXME("D3DPROCESSVERTICES_UPDATEEXTENTS not implemented.\n");
+                    }
                     if (ci->dwFlags & D3DPROCESSVERTICES_NOCOLOR)
                         FIXME("D3DPROCESSVERTICES_NOCOLOR not implemented.\n");
 
-- 
2.13.6

[Henri Verbeet]

On 12 May 2018 at 17:26, Gijs Vermeulen <gijsvrm(a)gmail.com> wrote:
> From: Christian Costa <titan.costa(a)gmail.com>
>
> Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com>
> ---
>
> Fixes noisy fixme that floods the console (> 1000) in VENOM. CODENAME: OUTBREAK.
>
> dlls/ddraw/executebuffer.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Looks like I missed this patch initially, my apologies.

As for the patch itself, if you have an application that uses this,
I'd prefer implementing the functionality over silencing the FIXME.
Updating the extents should be a fairly straightforward change in
process_vertices_strided() in wined3d. Getting that data back to the
application will require some plumbing, but shouldn't be hard.