Re: msvcrt: Fix _ismbblead test: Make it pass on windows

[Vitaliy Margolen]

Any reason why this patch wasn't committed?
http://www.winehq.com/pipermail/wine-patches/2005-October/021091.html

Vitaliy Margolen

Saturday, October 1, 2005, 11:58:45 AM, Vitaliy Margolen wrote:
> This test clearly fails on all windows versions.
> Vitaliy Margolen
> changelog:
>   msvcrt:
>     Fix _ismbblead test: Make it pass on windows

msvcrt: Fix _ismbblead test: Make it pass on windows

[Vijay Kiran Kamuju]

well you are try to make it pass on wine, but the behavior on windows
is different.
It returns 4, but wine returns 1.

On 10/8/05, Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote:
> Any reason why this patch wasn't committed?
> http://www.winehq.com/pipermail/wine-patches/2005-October/021091.html
>
> Vitaliy Margolen
>
> Saturday, October 1, 2005, 11:58:45 AM, Vitaliy Margolen wrote:
> > This test clearly fails on all windows versions.
> > Vitaliy Margolen
> > changelog:
> >   msvcrt:
> >     Fix _ismbblead test: Make it pass on windows

msvcrt: Fix _ismbblead test: Make it pass on windows

[James Hawkins]

On 10/8/05, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote:
> well you are try to make it pass on wine, but the behavior on windows
> is different.
> It returns 4, but wine returns 1.

Vitaliy isn't trying to make the test pass on wine, but in Windows. 
It's still marked todo_wine which means the test still fails in wine. 
Wine returns 0, not 1.

--
James Hawkins

msvcrt: Fix _ismbblead test: Make it pass on windows

[Vitaliy Margolen]

Friday, October 7, 2005, 11:30:15 PM, James Hawkins wrote:
> On 10/8/05, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote:
> > well you are try to make it pass on wine, but the behavior on windows
> > is different.
> > It returns 4, but wine returns 1.
> Vitaliy isn't trying to make the test pass on wine, but in Windows. 
> It's still marked todo_wine which means the test still fails in wine. 
> Wine returns 0, not 1.

Yep, that's what I'm trying to do ;-) Vijay I'm not sure if you know the place
where all the windows tests a collected here it is: http://test.winehq.org/data/
You could see that this test is failing for a long time. And I don't know where
the author of that test got the result from. I have all codepages installed on
my win2k system, so there is no question about selecting requested codepage.

Vitaliy