Re: Add stub function HWND GetConsoleWindow()

[Dmitry Timoshkov]

"Ylia K" <k_ilya(a)ukr.net> wrote:
> * dlls/kernel/kernel32.spec, dlls/kernel/console.c, include/wincon.h
>  Ilya Korniyko <k_ilya(a)ukr.net>
>  Add stub function HWND GetConsoleWindow()
>
> It is for excelent file manager FAR Manager (www.rarlab.com). 
> FAR Manager doesn't run without this patch.
> With patch it runs - good on winXP, very bad on winME.

I'm wondering how your patch works at all, the call should smash
the stack since it misses WINAPI modifier.

-- 
Dmitry.

Add stub function HWND GetConsoleWindow()

[Mike Hearn]

On Mon, 26 Apr 2004 23:50:35 +0900, Dmitry Timoshkov wrote:
> I'm wondering how your patch works at all, the call should smash
> the stack since it misses WINAPI modifier.

In some circumstances apps can survive stack corruption caused by
incorrect calling conventions. There was a good entry in Raymond Chens
blog about this a few months ago, explaining why and how Windows repairs
the stack in particular situations.

Add stub function HWND GetConsoleWindow()

[Dmitry Timoshkov]

"Mike Hearn" <mh(a)codeweavers.com> wrote:
> In some circumstances apps can survive stack corruption caused by
> incorrect calling conventions. There was a good entry in Raymond Chens
> blog about this a few months ago, explaining why and how Windows repairs
> the stack in particular situations.

Filip Navara already pointed out to me privately that since GetConsoleWindow
takes no params there should not be any problem with calling conventions used.

Anyway WINAPI is mandatory for GetConsoleWindow in order to at least get
correct stdcall decoration in an import library generated under MinGW.

-- 
Dmitry.

Re[2]: Add stub function HWND GetConsoleWindow()

[Ylia K]

-----Original Message-----
From: "Dmitry Timoshkov" <dmitry(a)baikal.ru>
To: "Ylia K" <k_ilya(a)ukr.net>
Date: Mon, 26 Apr 2004 23:50:35 +0900
Subject: Re: Add stub function HWND GetConsoleWindow()
> "Ylia K" <k_ilya(a)ukr.net> wrote:
> > * dlls/kernel/kernel32.spec, dlls/kernel/console.c, include/wincon.h
> >  Ilya Korniyko <k_ilya(a)ukr.net>
> >  Add stub function HWND GetConsoleWindow()
> >
> > It is for excelent file manager FAR Manager (www.rarlab.com). 
> > FAR Manager doesn't run without this patch.
> > With patch it runs - good on winXP, very bad on winME.
>
> I'm wondering how your patch works at all, the call should smash
> the stack since it misses WINAPI modifier.
>
> -- 
> Dmitry.

Yes I missed it :( But it works for me somehow! 
Though this function is already added in latest release, without my patch (only to .spec & .c , not ot wincon.h)

----------------
  Best Regards,
  Ilya Korniyko