Re: [1/2] explorer: Initial implementation of desktop launchers.

[Qian Hong]

Hello Hans,

On Tue, May 28, 2013 at 6:42 PM, Hans Leidekker <hans(a)codeweavers.com> wrote:
> +    hr = SHGetKnownFolderPath( &FOLDERID_Desktop, 0, NULL, &desktop_folder );
> +    if (FAILED( hr ))
> +    {
> +        WINE_ERR("Could not get user desktop folder\n");
> +        return;
> +    }
> +    hr = SHGetKnownFolderPath( &FOLDERID_PublicDesktop, 0, NULL, &desktop_folder_public );
> +    if (FAILED( hr ))
> +    {
> +        WINE_ERR("Could not get public desktop folder\n");
> +        CoTaskMemFree( desktop_folder );
> +        return;
> +    }

Does KF_FLAG_CREATE look better here? Other wise every time a new
wineprefix created there is an err output.
Maybe I'm missing something here, thanks for your work.



--
Regards,
Qian Hong

-
http://www.winehq.org

[1/2] explorer: Initial implementation of desktop launchers.

[Hans Leidekker]

On Fri, 2013-05-31 at 03:30 +0800, Qian Hong wrote:
> On Tue, May 28, 2013 at 6:42 PM, Hans Leidekker <hans(a)codeweavers.com> wrote:
> > +    hr = SHGetKnownFolderPath( &FOLDERID_Desktop, 0, NULL, &desktop_folder );
> > +    if (FAILED( hr ))
> > +    {
> > +        WINE_ERR("Could not get user desktop folder\n");
> > +        return;
> > +    }
> > +    hr = SHGetKnownFolderPath( &FOLDERID_PublicDesktop, 0, NULL, &desktop_folder_public );
> > +    if (FAILED( hr ))
> > +    {
> > +        WINE_ERR("Could not get public desktop folder\n");
> > +        CoTaskMemFree( desktop_folder );
> > +        return;
> > +    }
>
> Does KF_FLAG_CREATE look better here? Other wise every time a new

Yes, that makes sense.