Re: [PATCH v2 1/5] user32: Fix handling of internal messages.

[Alexandre Julliard]

Zebediah Figura <z.figura12(a)gmail.com> writes:
> This patch adds a new flag and a server reply, allowing GetQueueStatus
> to ignore internal messages, and MsgWaitForMultipleObjects to process
> internal messages until a real sent message is found.

There's a lot of code duplication in there, and adding private flags to
public headers is discouraged. There has to be a better way of doing
this, or else it would need a stronger justification than a couple of
EnableWindow tests.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH v2 1/5] user32: Fix handling of internal messages.

[Zebediah Figura]

On 03/24/2017 04:23 PM, Alexandre Julliard wrote:
> Zebediah Figura <z.figura12(a)gmail.com> writes:
> > This patch adds a new flag and a server reply, allowing GetQueueStatus
> > to ignore internal messages, and MsgWaitForMultipleObjects to process
> > internal messages until a real sent message is found.
>
> There's a lot of code duplication in there, and adding private flags to
> public headers is discouraged. There has to be a better way of doing
> this, or else it would need a stronger justification than a couple of
> EnableWindow tests.

I'll get rid of this patch and resubmit the others, then. My main
motivation was trying to fix an intermittent failure (bug #42568), but
it is probably better to try to submit a workaround for that.