Henri Verbeet <hverbeet(a)gmail.com> wrote:
On 14 July 2010 16:26, Dan Kegel <dank(a)kegel.com> wrote:
If you ask me, http://bugs.winehq.org/show_bug.cgi?id=6971#c371 is more objectionable, because it shows the Wine community to be ill-mannered and hostile to newbies. Sure, it could have been worded more carefully, but I don't buy the "taints us all" theory.
However, if we're talking about being harmful to the project, I think it's far more insidious and actively harmful to pretend being an active / respected Wine developer and giving potential new developers bad advice from that position. Because what happens is that those people take that advice in good faith, start writing patches, and perhaps even develop some habits based on it. But when those patches then hit wine-patches and get shot down during review, it's the reviewers that get blamed for being "picky" or "harsh", while in some cases the entire premise on which those patches are based is simply wrong. I think that does far more harm to new developers than "being mean to someone on the internet".
Of course with Wine being an open project there's not a whole lot we can do about people saying whatever they like, except perhaps teaching potential new developers about things like "git shortlog -s -n --since={5year}".
On that vein of thought, why don't we have a code standard page? I've been asking this question and maybe this should be my next area of concern after the release of Wine 1.2 and the reinput of my patches. This way, I can use my 'years of expertise' and what I've learned about this project as far as coding practices. I don't want to wait on AJ to do this. James McKenzie
Am 15.07.2010 18:29, schrieb James Mckenzie:
On that vein of thought, why don't we have a code standard page? I've been asking this question and maybe this should be my next area of concern after the release of Wine 1.2 and the reinput of my patches. This way, I can use my 'years of expertise' and what I've learned about this project as far as coding practices. I don't want to wait on AJ to do this.
James McKenzie
http://wiki.jswindle.com tries to write some Wine coding standards, its somehow successful but too less people know about. e.g. i just found that page because he quoted me :) -- Best Regards, André Hentschel
James Mckenzie <jjmckenzie51(a)earthlink.net> wrote:
On that vein of thought, why don't we have a code standard page? I've been asking this question and maybe this should be my next area of concern after the release of Wine 1.2 and the reinput of my patches. This way, I can use my 'years of expertise' and what I've learned about this project as far as coding practices. I don't want to wait on AJ to do this.
This doesn't belong to you since you don't send patches anyway and just doing advices as Henri pointed out despite claming "years of expertise", but people who do can always follow basic rule from http://wiki.winehq.org/SubmittingPatches: "Try to imitate wine-patches style" which also can be used for coding style. -- Dmitry.
participants (3)
-
André Hentschel -
Dmitry Timoshkov -
James Mckenzie