Re: [PATCH v2] hidclass.sys: Handle POP and PUSH in device descriptors

[Sebastian Lackner]

On 14.11.2016 15:08, Aric Stewart wrote:
> +    if (!list_empty(&caps_stack))
> +    {
> +        struct caps_stack *entry, *cursor;
> +        ERR("%i unpopped device caps on the stack\n", list_count(&caps_stack));
> +        LIST_FOR_EACH_ENTRY_SAFE(entry, cursor, &caps_stack, struct caps_stack, entry)
> +            list_remove(&entry->entry);

I assume you also wanted to deallocate the remaining blocks?
> +    }

[PATCH v2] hidclass.sys: Handle POP and PUSH in device descriptors

[Aric Stewart]

On 11/14/16 8:22 AM, Sebastian Lackner wrote:
> On 14.11.2016 15:08, Aric Stewart wrote:
> > +    if (!list_empty(&caps_stack))
> > +    {
> > +        struct caps_stack *entry, *cursor;
> > +        ERR("%i unpopped device caps on the stack\n", list_count(&caps_stack));
> > +        LIST_FOR_EACH_ENTRY_SAFE(entry, cursor, &caps_stack, struct caps_stack, entry)
> > +            list_remove(&entry->entry);
>
> I assume you also wanted to deallocate the remaining blocks?

Doh, yes, since that is the whole point. Thanks!

-aric
> > +    }