Re: Unused functions in fusion.dll

[Paul Vriens]

Luke Benstead wrote:
> 2009/5/14 Paul Vriens <paul.vriens.wine(a)gmail.com>:
> > Paul Vriens wrote:
> > > Francois Gouget wrote:
> > > > The following fusion.dll functions are unused: nobody calls them and they
> > > > are not exported.
> > > >
> > > > CompareAssemblyIdentity()
> > > >  GetAssemblyIdentityFromFile()
> > > >
> > > > I checked a Windows fusion.dll I have here and I did not see them being
> > > > exported there either. Yet, the MSDN documents them and presumably there's a
> > > > way a application can call them...
> > > >
> > > > Does anyone know what's up?
> > > >
> > > > ------------------------------------------------------------------------
> > >
> > > What version of the .NET framework do you have? It looks like these came
> > > with 2.0
> >
> > Forget that remark. Just checked both fusion and mscoree on .NET 1.1 and 3.5
> > and neither have these exports.
> >
> > So, no clue ;)
> >
> > --
> > Cheers,
> >
> > Paul.
>
> Just a pure guess, but Googling for CompareAssemblyIdentity returns
> this: http://forums.iis.net/t/1149942.aspx which shows:
>
> mscorwks!CompareAssemblyIdentity+b04a
>
> Is it possible that the actual exported CompareAssemblyIdentity (and
> the one documented on MSDN) should be in mscorwks.dll and NOT in
> fusion.dll?
>
> Just thinking aloud.
>
> Luke.
> Spot on:

(Vista with .NET3.5SP1):

winedump -v -j export mscorwks.dll | grep -e CompareAssemblyIdentity -e 
GetAssemblyIdentityFromFile

   002FF322    48 CompareAssemblyIdentity
   00300A41    69 GetAssemblyIdentityFromFile

(W2K3 with .NET1.1):

not present

(W2K3 with .NET2.0):

   000F3C2F    47 CompareAssemblyIdentity
   002DE14F    68 GetAssemblyIdentityFromFile

(W2K3 / .NET 2.0SP1/3.0/3.0SP1/3.5):

   0013A67D    47 CompareAssemblyIdentity
   003277D3    68 GetAssemblyIdentityFromFile

(W2K3 with .NET 3.5SP1):

   002FF132    48 CompareAssemblyIdentity
   00300851    69 GetAssemblyIdentityFromFile

-- 
Cheers,

Paul.

Unused functions in fusion.dll

[Francois Gouget]

On Thu, 14 May 2009, Paul Vriens wrote:
[...]
> Spot on:
>
> (Vista with .NET3.5SP1):
>
> winedump -v -j export mscorwks.dll | grep -e CompareAssemblyIdentity -e
> GetAssemblyIdentityFromFile
>
> 002FF322    48 CompareAssemblyIdentity
>   00300A41    69 GetAssemblyIdentityFromFile

So given that we don't have an mscorwks implementation and that these 
are just stubs, it seems like they should be removed from fusion.dll.

I'll send a patch.

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
  Good judgment comes from experience, and experience comes from bad judgment
                               -- Barry LePatner