[PATCH 0/1] MR107: mscoree/tests: Use wait_child_process for csc process.
I'm hoping this will help with the recent mscoree:comtest failures. Based on the test output, it appears that the 5 second wait is timing out. I was going to just add time, but, well, it would also be nice to check the return value of the wait, and we already have a function that does that so... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/107
From: Esme Povirk <esme(a)codeweavers.com> Signed-off-by: Esme Povirk <esme(a)codeweavers.com> --- dlls/mscoree/tests/comtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mscoree/tests/comtest.c b/dlls/mscoree/tests/comtest.c index aa23032f18f..db6acac1e9e 100644 --- a/dlls/mscoree/tests/comtest.c +++ b/dlls/mscoree/tests/comtest.c @@ -94,7 +94,7 @@ static BOOL compile_cs_to_dll(char *source_path, char *dest_path) ret = CreateProcessA(path_csc, cmdline, NULL, NULL, FALSE, 0, NULL, NULL, &si, &pi); ok(ret, "Could not create process: %lu\n", GetLastError()); - WaitForSingleObject(pi.hProcess, 5000); + wait_child_process(pi.hProcess); CloseHandle(pi.hThread); CloseHandle(pi.hProcess); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/107
participants (2)
-
Esme (@madewokherd) -
Esme Povirk