Re: [v2 6/6] d3dx9/tests: Add test for CommitChanges in effect.

[Matteo Bruni]

2017-03-14 13:47 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>:
> Signed-off-by: Paul Gofman <gofmanp(a)gmail.com>

I haven't looked in detail to this patch, just a couple bits I noticed.
> +    for (i = 0; i < sizeof(check_op_parameters) / sizeof(*check_op_parameters); ++i)

You can use ARRAY_SIZE() here too.
> +    {
> +        unsigned int j;
> +
> +        for (j = 0; j < 8; ++j)
> +        {
> +            hr = IDirect3DDevice9_SetLight(device, j, &test_effect_preshader_light_empty);
> +            ok(hr == D3D_OK, "Got result %#x.\n", hr);

Please add the values of i and j to the message.