Re: [PATCH 02/10] oleaut32: Improved ICreateTypeInfo2_fnAddFuncDesc implementation

[Paul Vriens]

On 02/22/2010 01:57 AM, Piotr Caban wrote:
> +    TRACE("(%p,%d,%p)\n", iface, index, pFuncDesc);
> +    TRACE("{%d,%p,%p,%d,%d,%d,%d,%d,%d,%d,{%d},%d}\n", pFuncDesc->memid,
> +            pFuncDesc->lprgscode, pFuncDesc->lprgelemdescParam, pFuncDesc->funckind,
> +            pFuncDesc->invkind, pFuncDesc->callconv, pFuncDesc->cParams,
> +            pFuncDesc->cParamsOpt, pFuncDesc->oVft, pFuncDesc->cScodes,
> +            pFuncDesc->elemdescFunc.tdesc.vt, pFuncDesc->wFuncFlags);
> +
> +    if(!pFuncDesc || (pFuncDesc->memid>0x7fffffff&&  pFuncDesc->memid!=MEMBERID_NIL))
> +        return E_INVALIDARG;

Hi Piotr,

Your checking pFuncDesc for NULL after using it's members in the 
TRACE(). At least Coverity will throw up an error on that.

-- 
Cheers,

Paul.