Re: [PATCH 4/4] [Kernel32]: add ability to load additional terminfo data from Wine registry

[Eric Pouech]

Le 19/01/2011 13:07, Alexandre Julliard a écrit :
> Eric Pouech<eric.pouech(a)orange.fr>  writes:
> > you mean hardwiring the missing keys (potentially different according to
> > terminal type) in the code?
> > If they depend on terminal type they belong in terminfo, not in the
> > registry.

as I said, terminfo is not fully populated
it misses lots of ctrl-<key> (left arrow, right arrow...) and has not 
been updated lately
most of the common text editors come with their own config files
for example, /etc/inputrc has the missing bindings for libreadline (and 
of course it depends on $TERM)
so, updating terminfo isn't the solution

would you consider inclusion in hklm (instead of hkcu) ?
A+

-- 
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

[PATCH 4/4] [Kernel32]: add ability to load additional terminfo data from Wine registry

[Alexandre Julliard]

Eric Pouech <eric.pouech(a)orange.fr> writes:
> as I said, terminfo is not fully populated
> it misses lots of ctrl-<key> (left arrow, right arrow...) and has not
> been updated lately
> most of the common text editors come with their own config files
> for example, /etc/inputrc has the missing bindings for libreadline
> (and of course it depends on $TERM)
> so, updating terminfo isn't the solution
>
> would you consider inclusion in hklm (instead of hkcu) ?

If it's user-editable, it has to be in HKCU, with proper defaults in the
code because we don't want to create user keys from wine.inf. Plus of
course the format has to be something that users can understand, it
can't be a binary array. Basically you'd have to replicate inputrc
inside the registry, I'm not sure it's worth the trouble.

-- 
Alexandre Julliard
julliard(a)winehq.org