Hello there, I'm still on tests for mscoree, and for that I need NET dlls to run the tests with. The DLLs can be compile with csc.exe, but that needs to be implemented somehow. Right now there are two ways we could implement that: 1) Compile DLL at build time (optional build dependency on mono) 2) Compile DLL at runtime (wine-mono would need to ship csc.exe, native .NET already has it) I'm not sure which way is preferred, both would be feasible, I guess. Which one should I take? Regards, Fabian Maurer
On Wed, Aug 1, 2018 at 1:45 PM, Fabian Maurer <dark.shadow4(a)web.de> wrote:
Hello there,
I'm still on tests for mscoree, and for that I need NET dlls to run the tests with.
The DLLs can be compile with csc.exe, but that needs to be implemented somehow.
Right now there are two ways we could implement that:
1) Compile DLL at build time (optional build dependency on mono)
2) Compile DLL at runtime (wine-mono would need to ship csc.exe, native .NET already has it)
I'm not sure which way is preferred, both would be feasible, I guess.
Which one should I take?
Vincent already suggested option 2 (https://www.winehq.org/pipermail/wine-devel/2018-July/129995.html). I'm inclined to agree for a few reasons: A) This avoids a dependency on mono. B) It gives us a good reason to provide csc.exe, which would allow wine-mono to more closely match .Net. -- -Austin GPG: 267B CC1F 053F 0749 (expires 2021/02/18)
Yeah, makes sense to me. Do we have an official process on how to send patches to wine-mono? Because AFAIK there is only the github repo. On a side note, I'd like to make functions to test.h to handle the compilation so that doesn't need to be duplicated in every test that wants to use C# DLLs. Would that be alright? Regards, Fabian Maurer
Do we have an official process on how to send patches to wine-mono? Because AFAIK there is only the github repo.
No formal process, but I prefer a pull request.
On a side note, I'd like to make functions to test.h to handle the compilation so that doesn't need to be duplicated in every test that wants to use C# DLLs. Would that be alright?
I can't think of anything other than mscoree that would need this. If there is, I think duplication will be fine.
On Thu, 2 Aug 2018 at 18:38, Fabian Maurer <dark.shadow4(a)web.de> wrote:
No formal process, but I prefer a pull request.
Will do.
I can't think of anything other than mscoree that would need this. If
there is, I think duplication will be fine.
Well the test for SxsLookupClrGuid should probably be in sxs tests, so we'd need it there, too.
I think sxs one only needs appropriate context data, not the modules.
participants (4)
-
Austin English -
Fabian Maurer -
Nikolay Sivov -
Vincent Povirk