Re: [PATCH 1/5] wined3d: Don't bother about client storage in wined3d_surface_set_mem.

[Henri Verbeet]

On 4 October 2013 00:03, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> @@ -2883,10 +2886,6 @@ HRESULT CDECL wined3d_surface_set_mem(struct wined3d_surface *surface, void *mem
>          /* Now the surface memory is most up do date. Invalidate drawable and texture. */
>          surface_validate_location(surface, SFLAG_INSYSMEM);
>          surface_invalidate_location(surface, ~SFLAG_INSYSMEM);
> -
> -        /* For client textures OpenGL has to be notified. */
> -        if (surface->flags & SFLAG_CLIENT)
> -            surface_release_client_storage(surface);
>      }
>      else if (surface->flags & SFLAG_USERPTR)
>      {
> @@ -2899,9 +2898,6 @@ HRESULT CDECL wined3d_surface_set_mem(struct wined3d_surface *surface, void *mem
>              surface->resource.allocatedMemory = NULL;
>              surface->flags &= ~(SFLAG_USERPTR | SFLAG_INSYSMEM);
>
> -            if (surface->flags & SFLAG_CLIENT)
> -                surface_release_client_storage(surface);
> -
>              surface_prepare_system_memory(surface);
>          }

What makes this safe, and why is it needed?