Re: Alexander Nicolaysen Sørnes : regedit: Convert printing&help to unicode.

[Eric Pouech]

Alexandre Julliard a écrit :
> Module: wine
> Branch: master
> Commit: 5cb8bccf462790338677dac3bfb394df8f4da020
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5cb8bccf462790338677dac3bf...
>
> Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>
> Date:   Sun Aug 10 12:43:06 2008 +0200
>
> regedit: Convert printing&help to unicode.
>
> ---
>
> programs/regedit/framewnd.c |   25 +++++++++++++++++--------
>  1 files changed, 17 insertions(+), 8 deletions(-)
>
> @@ -671,8 +671,11 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
>      case ID_REGISTRY_DISCONNECTNETWORKREGISTRY:
>          break;
>      case ID_REGISTRY_PRINT:
> -        PrintRegistryHive(hWnd, _T(""));
> +    {
> +        const WCHAR empty = 0;
> +        PrintRegistryHive(hWnd, empty);
>          break;
> +    }

this looks very wrong to me

-- 
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Alexander Nicolaysen Sørnes : regedit: Convert printing&help to unicode.

[Alexander Nicolaysen Sørnes]

På Onsdag 20 august 2008 , 19:30:44 skrev Eric Pouech:
> Alexandre Julliard a écrit :
> > Module: wine
> > Branch: master
> > Commit: 5cb8bccf462790338677dac3bfb394df8f4da020
> > URL:   
> > http://source.winehq.org/git/wine.git/?a=commit;h=5cb8bccf462790338677dac
> > 3bfb394df8f4da020
> >
> > Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>
> > Date:   Sun Aug 10 12:43:06 2008 +0200
> >
> > regedit: Convert printing&help to unicode.
> >
> > ---
> >
> > programs/regedit/framewnd.c |   25 +++++++++++++++++--------
> >  1 files changed, 17 insertions(+), 8 deletions(-)
> >
> > @@ -671,8 +671,11 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message,
> > WPARAM wParam, LPARAM lParam) case ID_REGISTRY_DISCONNECTNETWORKREGISTRY:
> >          break;
> >      case ID_REGISTRY_PRINT:
> > -        PrintRegistryHive(hWnd, _T(""));
> > +    {
> > +        const WCHAR empty = 0;
> > +        PrintRegistryHive(hWnd, empty);
> >          break;
> > +    }
>
> this looks very wrong to me

Prinitng isn't actually implemented in regedit; I just changed the little bit 
of code that was there.  Is it wrong to do
> > +        const WCHAR empty = 0;
> > +        PrintRegistryHive(hWnd, empty);

to send an empty string?

Thanks for reviewing the changes!


Alexander N. Sørnes

Alexander Nicolaysen Sørnes : regedit: Convert printing&help to unicode.

[Michael Karcher]

Am Mittwoch, den 20.08.2008, 19:55 +0200 schrieb Alexander Nicolaysen
Sørnes:
> > > +        const WCHAR empty = 0;
> > > +        PrintRegistryHive(hWnd, empty);
>
> to send an empty string?

It is. This sends a NULL pointer (empty is 0, converted to a pointer is
a NULL pointer). You mean "&empty".

Regards,
  Michael Karcher

Alexander Nicolaysen Sørnes : regedit: Convert printing&help to unicode.

[Eric Pouech]

Alexander Nicolaysen Sørnes a écrit :
> På Onsdag 20 august 2008 , 19:30:44 skrev Eric Pouech:
> > Alexandre Julliard a écrit :
> > > Module: wine
> > > Branch: master
> > > Commit: 5cb8bccf462790338677dac3bfb394df8f4da020
> > > URL:   
> > > http://source.winehq.org/git/wine.git/?a=commit;h=5cb8bccf462790338677dac
> > > 3bfb394df8f4da020
> > >
> > > Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>
> > > Date:   Sun Aug 10 12:43:06 2008 +0200
> > >
> > > regedit: Convert printing&help to unicode.
> > >
> > > ---
> > >
> > > programs/regedit/framewnd.c |   25 +++++++++++++++++--------
> > >  1 files changed, 17 insertions(+), 8 deletions(-)
> > >
> > > @@ -671,8 +671,11 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message,
> > > WPARAM wParam, LPARAM lParam) case ID_REGISTRY_DISCONNECTNETWORKREGISTRY:
> > >          break;
> > >      case ID_REGISTRY_PRINT:
> > > -        PrintRegistryHive(hWnd, _T(""));
> > > +    {
> > > +        const WCHAR empty = 0;
> > > +        PrintRegistryHive(hWnd, empty);
> > >          break;
> > > +    }
> >
> > this looks very wrong to me
>
> Prinitng isn't actually implemented in regedit; I just changed the little bit 
> of code that was there.  Is it wrong to do
> > > +        const WCHAR empty = 0;
> > > +        PrintRegistryHive(hWnd, empty);
>
> to send an empty string?
>
> Thanks for reviewing the changes!
>
> Alexander N. Sørnes

the code should be PrintRegistryHive(hWnd, &empty);
A+

-- 
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Alexander Nicolaysen Sørnes : regedit: Convert printing&help to unicode.

[Alexander Nicolaysen Sørnes]

På Onsdag 20 august 2008 , 20:09:40 skrev du:
> Alexander Nicolaysen Sørnes a écrit :
> > På Onsdag 20 august 2008 , 19:30:44 skrev Eric Pouech:
> > > Alexandre Julliard a écrit :
> > > > Module: wine
> > > > Branch: master
> > > > Commit: 5cb8bccf462790338677dac3bfb394df8f4da020
> > > > URL:
> > > > http://source.winehq.org/git/wine.git/?a=commit;h=5cb8bccf462790338677d
> > > > ac 3bfb394df8f4da020
> > > >
> > > > Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>
> > > > Date:   Sun Aug 10 12:43:06 2008 +0200
> > > >
> > > > regedit: Convert printing&help to unicode.
> > > >
> > > > ---
> > > >
> > > > programs/regedit/framewnd.c |   25 +++++++++++++++++--------
> > > >  1 files changed, 17 insertions(+), 8 deletions(-)
> > > >
> > > > @@ -671,8 +671,11 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message,
> > > > WPARAM wParam, LPARAM lParam) case
> > > > ID_REGISTRY_DISCONNECTNETWORKREGISTRY: break;
> > > >      case ID_REGISTRY_PRINT:
> > > > -        PrintRegistryHive(hWnd, _T(""));
> > > > +    {
> > > > +        const WCHAR empty = 0;
> > > > +        PrintRegistryHive(hWnd, empty);
> > > >          break;
> > > > +    }
> > >
> > > this looks very wrong to me
> >
> > Prinitng isn't actually implemented in regedit; I just changed the little
> > bit of code that was there.  Is it wrong to do
> > > > +        const WCHAR empty = 0;
> > > > +        PrintRegistryHive(hWnd, empty);
> >
> > to send an empty string?
> >
> > Thanks for reviewing the changes!
> >
> > Alexander N. Sørnes
>
> the code should be PrintRegistryHive(hWnd, &empty);
> A+

Oh, I feel so stupid!  That was what I intended to do.  Thanks again for 
noticing