Re: [PATCH] shlwapi: Fix pointer and size in AssocQueryStringA
16 Oct
2008
16 Oct
'08
11:37 p.m.
Hi Detlef, - if (dwLenOut >= MAX_PATH) + if (dwLenOut >= MAX_PATH) { lpszReturnW = HeapAlloc(GetProcessHeap(), 0, (dwLenOut + 1) * sizeof(WCHAR)); + } This first set of parentheses seems like an unnecessary addition.. + else + { + dwLenOut = sizeof(szReturnW) / sizeof(szReturnW[0]); + } and this one's style doesn't match the above. The rest of the file doesn't appear to use braces with only a single-line expression, so would you mind sticking with the existing style? Same with the next hunk, it introduces braces where none are needed. Thanks, --Juan
6357
Age (days ago)
6357
Last active (days ago)
0 comments
1 participants
participants (1)
-
Juan Lang