Re: Nikolay Sivov : advapi32: Free descriptor if it isn' t returned from GetSecurityInfo().

[Rob Shearman]

2010/1/11 Alexandre Julliard <julliard(a)winehq.org>:
> Module: wine
> Branch: master
> Commit: dbd76575ef8353484afa0b0d2da95760c26f34fe
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=dbd76575ef8353484afa0b0d2d...
>
> Author: Nikolay Sivov <bunglehead(a)gmail.com>
> Date:   Fri Jan  8 21:05:21 2010 +0300
>
> advapi32: Free descriptor if it isn't returned from GetSecurityInfo().
>
> ---
>
>  dlls/advapi32/security.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c
> index 629a74a..babe468 100644
> --- a/dlls/advapi32/security.c
> +++ b/dlls/advapi32/security.c
> @@ -3118,6 +3118,8 @@ DWORD WINAPI GetSecurityInfo(
>     }
>     if (ppSecurityDescriptor)
>         *ppSecurityDescriptor = sd;
> +    else
> +        LocalFree(sd);
>
>     return ERROR_SUCCESS;
>  }

This is not correct as per the discussion on wine-devel, so it needs
to be reverted. It causes these new Valgrind warnings:
http://kegel.com/wine/valgrind/logs/2010-01-11-14.17/diff-advapi32_security....

-- 
Rob Shearman

Nikolay Sivov : advapi32: Free descriptor if it isn' t returned from GetSecurityInfo().

[Nikolay Sivov]

On 1/12/2010 13:45, Rob Shearman wrote:
> This is not correct as per the discussion on wine-devel, so it needs
> to be reverted. It causes these new Valgrind warnings:
> http://kegel.com/wine/valgrind/logs/2010-01-11-14.17/diff-advapi32_security....

Yes, it was to fast for me, there's nothing to fix. Alexandre, please 
revert this. Or should I send reverting patch?