Re: [PATCH] async IO APCs call check_async_list() directly
Hi Martin, I think this is a better way to do things, but it might be better to submit this patch against the current CVS rather than against CVS+previous patch. Mike Original message from: Martin Wilck <Martin.Wilck(a)fujitsu-siemens.com>
PATCH: async-func.diff
This is an improvement over my previous patch (async-struct.diff) in that it does not need the static function check_async_lists in several source files anymore and still achieves DLL separation.
The idea is that all async I/O requests use check_async_list as
callback function
anyway, so that there is no need to pass a function pointer. I discussed the idea with Mike, and he seemed to like it.
Patch against: Wine CVS 2002/04/04, with my async-struct patch applied. Test status: Compiles warnings. Tested regular file async IO (ok). Serial port async IO: a test would be desirable.
------------------------------------------ mailto:Mike_McCormack(a)start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au
Hi Mike,
I think this is a better way to do things, but it might be better to submit this patch against the current CVS rather than against CVS+previous patch.
I chose this way because it shows the changes more clearly. I can easily send the "combined" patch if this is desired. Do you have any other issues/criticisms wrt to the stuff I sent? Martin -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck(a)Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy
participants (2)
-
Martin Wilck -
Mike McCormack