Re: x11drv: don't consume Expose events when filter contains QS_PAINT

[Clinton Stimpson]

Clinton Stimpson wrote:
> Fix for bug 9875 (There are more details in that bug report if you want).
> Existance of update regions in the wine server correspond with WM_PAINT 
> existing in queue.  Existance of Expose events in the X event queue don't 
> correspond with update regions in the wine server, which can result in a loss 
> of painting some regions.
>
> Don't consume Expose events when filtering with QS_PAINT.

Anything wrong with this patch?

Thanks,
Clinton Stimpson

x11drv: don't consume Expose events when filter contains QS_PAINT

[Alexandre Julliard]

Clinton Stimpson <cjstimpson(a)utwire.net> writes:
> Clinton Stimpson wrote:
> > Fix for bug 9875 (There are more details in that bug report if you want).
> > Existance of update regions in the wine server correspond with WM_PAINT 
> > existing in queue.  Existance of Expose events in the X event queue don't 
> > correspond with update regions in the wine server, which can result in a loss 
> > of painting some regions.
> >
> > Don't consume Expose events when filtering with QS_PAINT.
>
> Anything wrong with this patch?

Yes, this will break redraws in many cases. Because of the async
nature of X we have to check for Expose events before doing a repaint.

-- 
Alexandre Julliard
julliard(a)winehq.org